Convert arp_responder.py script to python 3 #8697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the use of scapy 2.5.0 and also fixes an issue where ARP packets are not being sent out fast enough/in time for control plane ping packets to fail to respond. Signed-off-by: Saikrishna Arcot <[email protected]>
saiarcot895
force-pushed
the
arp-responder-python3
branch
from
3f43843
to
838f0fd
Compare
yxieca
approved these changes
Jul 21, 2023
kellyyeh
approved these changes
Jul 21, 2023
|
What branches do we need this to be cherry picked? 202205+ ? |
|
I don't think this should be cherry-picked; this should be on master branch only for sonic-mgmt (which, I think, covers 202211 branch and newer). If we really need this on 202205 branch, then the PTF container needs to be updated for 202205. |
6 tasks
yaqiangz
added a commit
that referenced
this pull request
Aug 9, 2023
What is the motivation for this PR? Missing part of this PR: #8697 would causes error while replying ndp. How did you do it? Remove useless parameter. How did you verify/test it? Run this script to reply ndp. Signed-off-by: Yaqiang Zhu <[email protected]>
6 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 9, 2023
What is the motivation for this PR? Missing part of this PR: sonic-net#8697 would causes error while replying ndp. How did you do it? Remove useless parameter. How did you verify/test it? Run this script to reply ndp. Signed-off-by: Yaqiang Zhu <[email protected]>
6 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Aug 9, 2023
What is the motivation for this PR? Missing part of this PR: #8697 would causes error while replying ndp. How did you do it? Remove useless parameter. How did you verify/test it? Run this script to reply ndp. Signed-off-by: Yaqiang Zhu <[email protected]>
yaqiangz
added a commit
that referenced
this pull request
Aug 9, 2023
What is the motivation for this PR? Introduced this PR: #8697. Missing specifying interface would causes that ipv6 reply packet is sent by default interface(sendrecv.py), which is incorrect. How did you do it? Specify send interface. How did you verify/test it? Run this script in ptf and ping ipv6 address from DUT, then run show ndp in DUT, address pinged before can be seen in ndp table. Run test_acl.py in m0 testbed, all passed. (This test case in m0 would trigger ndp reply) Signed-off-by: Yaqiang Zhu <[email protected]>
6 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 9, 2023
What is the motivation for this PR? Introduced this PR: sonic-net#8697. Missing specifying interface would causes that ipv6 reply packet is sent by default interface(sendrecv.py), which is incorrect. How did you do it? Specify send interface. How did you verify/test it? Run this script in ptf and ping ipv6 address from DUT, then run show ndp in DUT, address pinged before can be seen in ndp table. Run test_acl.py in m0 testbed, all passed. (This test case in m0 would trigger ndp reply) Signed-off-by: Yaqiang Zhu <[email protected]>
mssonicbld
pushed a commit
that referenced
this pull request
Aug 9, 2023
What is the motivation for this PR? Introduced this PR: #8697. Missing specifying interface would causes that ipv6 reply packet is sent by default interface(sendrecv.py), which is incorrect. How did you do it? Specify send interface. How did you verify/test it? Run this script in ptf and ping ipv6 address from DUT, then run show ndp in DUT, address pinged before can be seen in ndp table. Run test_acl.py in m0 testbed, all passed. (This test case in m0 would trigger ndp reply) Signed-off-by: Yaqiang Zhu <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
This allows the use of scapy 2.5.0 and also fixes an issue where ARP packets are not being sent out fast enough/in time for control plane ping packets to fail to respond. Signed-off-by: Saikrishna Arcot <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
What is the motivation for this PR? Missing part of this PR: sonic-net#8697 would causes error while replying ndp. How did you do it? Remove useless parameter. How did you verify/test it? Run this script to reply ndp. Signed-off-by: Yaqiang Zhu <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
What is the motivation for this PR? Introduced this PR: sonic-net#8697. Missing specifying interface would causes that ipv6 reply packet is sent by default interface(sendrecv.py), which is incorrect. How did you do it? Specify send interface. How did you verify/test it? Run this script in ptf and ping ipv6 address from DUT, then run show ndp in DUT, address pinged before can be seen in ndp table. Run test_acl.py in m0 testbed, all passed. (This test case in m0 would trigger ndp reply) Signed-off-by: Yaqiang Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
This allows the use of scapy 2.5.0 and also fixes an issue where ARP packets are not being sent out fast enough/in time, causing control plane ping packets to fail to respond.
This depends on the PTF container changes done in sonic-net/sonic-buildimage#15573.
Microsoft ADO: 24341848
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Ran
route/test_static_route.pyso that this script gets tested.Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation