-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GCU] update pfcwd interval config test #5662
Conversation
|
||
|
||
duthost.shell('config pfcwd start --action drop all 400 --restoration-time 400', module_ignore_errors=True) | ||
time.sleep(15) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 15 seconds? I see other code sleep 5 seconds. Still is it possible not to use magic number at all? For example, sleep until we find a signal that the config take effect.
@neethajohn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not need 15s. we can check immediately
The pre-commit check detected issues in the files touched by this pull request. For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
The pre-commit check detected issues in the files touched by this pull request. For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Previous version of test did not account for some configurations of Mellanox DUTs
How did you do it?
Write configuration into DUT
How did you verify/test it?
Verified on multiple physical Mellanox DUTs
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation