Add pfcwd interval config tests #4811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Dec 7, 2021
qiluo-msft
reviewed
Dec 7, 2021
qiluo-msft
reviewed
Dec 7, 2021
qiluo-msft
reviewed
Dec 7, 2021
wen587
reviewed
Jan 29, 2022
| cmd = "sudo pfcwd interval {}".format(value) | ||
| else: | ||
| cmd = "sonic-db-cli CONFIG_DB del \PFC_WD\GLOBAL\POLL_INTERVAL" | ||
|
|
There was a problem hiding this comment.
Seems we didn't run the cmd?
qiluo-msft
reviewed
Jan 29, 2022
| value: expected value of POLL_INTERVAL | ||
| """ | ||
| def _confirm_value_in_flex_counter_db(): | ||
| poll_interval = duthost.shell('redis-cli -n 5 hget FLEX_COUNTER_GROUP_TABLE:PFC_WD POLL_INTERVAL')["stdout"] |
qiluo-msft
approved these changes
Feb 2, 2022
|
Hi @isabelmsft , |
Hi @congh-nvidia , the pfcwd config was set by default on the DUTs I previously tested with, but thanks for asking- I did find that not all DUTs have this set by default. So I opened a new PR which configures pfcwd in the test: #5662 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
This PR will remain in draft mode until YANG model validation errors are resolved. Presently, the test case only runs successfully when the following YANG models are manually removed:
sonic-bgp-neighbor.yang
sonic-device_metadata.yang
sonic-feature.yang
sonic-flex_counter.yang
sonic-scheduler.yang
sonic-queue.yang
sonic-buffer-port-egress-profile-list.yang
sonic-buffer-port-ingress-profile-list.yang
Type of change
Back port request
Approach
What is the motivation for this PR?
Add pfcwd poll interval config tests
End to End test support for Generic Updater apply-patch
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation