Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a fixture to disable thermal policy #2953

Merged
merged 2 commits into from
Feb 16, 2021

Conversation

Junchao-Mellanox
Copy link
Contributor

Description of PR

Summary:
Add a fixture to disable thermal policy

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

In some test cases, thermal policy would override the mock value and cause test case failure sporadicly. So need a way to disable thermal policy during that test. The idea is to make thermalctld load an invalid thermal policy file. This PR provides a handy fixture to achieve this function.

How did you do it?

  1. add a fixture to disable thermal policy
  2. use this fixture in test_show_platform_fanstatus_mocked and test_device_checker

How did you verify/test it?

Manually run test_platform_info and test_snmp_phy_entity

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

N/A

Documentation

@Junchao-Mellanox
Copy link
Contributor Author

/AzurePipelines run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 2953 in repo Azure/sonic-mgmt

@jleveque
Copy link
Contributor

jleveque commented Feb 9, 2021

@Junchao-Mellanox: I'll run the test again.

@Junchao-Mellanox
Copy link
Contributor Author

thanks!

@liat-grozovik
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yxieca yxieca merged commit 50f5130 into sonic-net:master Feb 16, 2021
@Junchao-Mellanox Junchao-Mellanox deleted the disable_thermal_policy branch October 29, 2021 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants