Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sfp test for sonic-utilities PR#2953 #10914

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

congh-nvidia
Copy link
Contributor

@congh-nvidia congh-nvidia commented Nov 30, 2023

Description of PR

Summary:
Update sfp test for sonic-utilities PR(#2953 ). The output of "not implemented" error is changed in the PR, need to align the test.

Current output:
admin@sonic-01:~$ sudo sfputil show error-status --fetch-from-hardware
get_error_description NOT implemented for port Ethernet0

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305

Approach

What is the motivation for this PR?

Update sfp test for sonic-utilities PR#2953

How did you do it?

Please see the code change.

How did you verify/test it?

Run the test on dpu setup, test is skipped as expected.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Update sfp test for sonic utilities PR#2953
@congh-nvidia congh-nvidia requested a review from prgeor as a code owner November 30, 2023 11:11
@liat-grozovik liat-grozovik merged commit f1afd7c into sonic-net:master Dec 7, 2023
12 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Feb 1, 2024
- What is the motivation for this PR?
Update sfp test for sonic-utilities PR#2953

- How did you verify/test it?
Run the test on dpu setup, test is skipped as expected.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #11515

mssonicbld pushed a commit that referenced this pull request Feb 1, 2024
- What is the motivation for this PR?
Update sfp test for sonic-utilities PR#2953

- How did you verify/test it?
Run the test on dpu setup, test is skipped as expected.
@congh-nvidia congh-nvidia deleted the sfp branch October 17, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants