Modified tests/ipfwd/test_mtu.py testcase to run on T2 topology #2860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxygen980
changed the title
yxieca
reviewed
Jan 26, 2021
yxieca
reviewed
Jan 27, 2021
oxygen980
force-pushed
the
ipfwd_converted_to_t2
branch
from
6d44717 to
63469af
Compare
|
Please review. |
wangxin
requested changes
Feb 5, 2021
oxygen980
force-pushed
the
ipfwd_converted_to_t2
branch
from
63469af to
63bd856
Compare
|
This pull request introduces 1 alert when merging 63bd85610eb31f36514dd6ab7603efc7820c9ede into 1e70c8e - view on LGTM.com new alerts:
|
|
/AzurePipelines run |
|
Commenter does not have sufficient privileges for PR 2860 in repo Azure/sonic-mgmt |
|
retest vs image please |
oxygen980
force-pushed
the
ipfwd_converted_to_t2
branch
from
6b52ab7 to
4095a66
Compare
|
@wangxin Could you please review the changes ? |
wangxin
reviewed
Mar 2, 2021
added 5 commits
March 2, 2021 18:36
…t and dictionary of facts Changes made as per the review comment
oxygen980
force-pushed
the
ipfwd_converted_to_t2
branch
from
4095a66 to
58f1a4a
Compare
wangxin
approved these changes
Mar 3, 2021
6 tasks
liat-grozovik
pushed a commit
that referenced
this pull request
Aug 27, 2023
Added missed configuration in the calculation of headroom. Related configuration: #2860 - What is the motivation for this PR? Fix failed tests on setups with 800G: tests/qos/test_buffer.py::test_port_auto_neg tests/qos/test_buffer.py::test_lossless_pg[6] tests/qos/test_buffer.py::test_lossless_pg[3-4] - How did you do it? Added missed config - How did you verify/test it? Executed failed tests. Now they are passing Signed-off-by: AntonHryshchuk <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
Added missed configuration in the calculation of headroom. Related configuration: sonic-net#2860 - What is the motivation for this PR? Fix failed tests on setups with 800G: tests/qos/test_buffer.py::test_port_auto_neg tests/qos/test_buffer.py::test_lossless_pg[6] tests/qos/test_buffer.py::test_lossless_pg[3-4] - How did you do it? Added missed config - How did you verify/test it? Executed failed tests. Now they are passing Signed-off-by: AntonHryshchuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Modified tests/ipfwd/test_mtu.py testcase to run on multi-dut and for T2 topology.
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
Need the capability to run ipfwd/test_mtu.py testcase on T2 topology.
How did you do it?
ipfwd/test_mtu.py testcase is modified to run on multi-dut by taking dut related information from mg_facts and added support to run T2 topology.
How did you verify/test it?
Ran testcase on T2 topology.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation