-
Notifications
You must be signed in to change notification settings - Fork 746
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Modified tests/ipfwd/test_mtu.py testcase to run on T2 topology (#2860)
What is the motivation for this PR? Need the capability to run ipfwd/test_mtu.py testcase on T2 topology. How did you do it? ipfwd/test_mtu.py testcase is modified to run on multi-dut by taking dut related information from mg_facts and added support to run T2 topology. Co-authored-by: falodiya <[email protected]>
- Loading branch information
Showing
4 changed files
with
150 additions
and
123 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| import pytest | ||
| from ipaddress import ip_address | ||
| import logging | ||
| import json | ||
|
|
||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| ''' | ||
| In case of multi-dut we need src_host_ip, src_router_ip, dst_host_ip, src_ptf_port_list, dst_ptf_port_list for the dut under test, | ||
| to take care of that made changes in the testcase | ||
| ''' | ||
|
|
||
| def get_lag_facts(dut, lag_facts, switch_arptable, mg_facts, ignore_lags, key='src'): | ||
| if not mg_facts['minigraph_portchannels']: | ||
| pytest.fail("minigraph_portchannels is not defined") | ||
|
|
||
| # minigraph facts | ||
| selected_lag_facts = {} | ||
| up_lag = None | ||
| for a_lag_name, a_lag_data in lag_facts['lags'].items(): | ||
| if a_lag_data['po_intf_stat'] == 'Up' and a_lag_name not in ignore_lags: | ||
| # We found a portchannel that is up. | ||
| up_lag = a_lag_name | ||
| selected_lag_facts[key + '_port_ids'] = [mg_facts['minigraph_ptf_indices'][intf] for intf in a_lag_data['po_config']['ports']] | ||
| selected_lag_facts[key + '_router_mac'] = dut.facts['router_mac'] | ||
| for intf in mg_facts['minigraph_portchannel_interfaces']: | ||
| if intf['attachto'] == up_lag: | ||
| addr = ip_address(unicode(intf['addr'])) | ||
| if addr.version == 4: | ||
| selected_lag_facts[key + '_router_ipv4'] = intf['addr'] | ||
| selected_lag_facts[key + '_host_ipv4'] = intf['peer_addr'] | ||
| selected_lag_facts[key + '_host_mac'] = switch_arptable['arptable']['v4'][intf['peer_addr']]['macaddress'] | ||
| elif addr.version == 6: | ||
| selected_lag_facts[key + '_router_ipv6'] = intf['addr'] | ||
| selected_lag_facts[key + '_host_ipv6'] = intf['peer_addr'] | ||
| logger.info("{} lag is {}".format(key, up_lag)) | ||
| break | ||
|
|
||
| return up_lag, selected_lag_facts | ||
|
|
||
|
|
||
| def get_port_facts(dut, mg_facts, port_status, switch_arptable, ignore_intfs, key='src'): | ||
| if not mg_facts['minigraph_interfaces']: | ||
| pytest.fail("minigraph_interfaces is not defined.") | ||
| selected_port_facts = {} | ||
| up_port = None | ||
| for a_intf_name, a_intf_data in port_status['int_status'].items(): | ||
| if a_intf_data['oper_state'] == 'up' and a_intf_name not in ignore_intfs: | ||
| # Got a port that is up and not already used. | ||
| for intf in mg_facts['minigraph_interfaces']: | ||
| if intf['attachto'] == a_intf_name: | ||
| up_port = a_intf_name | ||
| selected_port_facts[key + '_port_ids'] = [mg_facts['minigraph_ptf_indices'][a_intf_name]] | ||
| selected_port_facts[key + '_router_mac'] = dut.facts['router_mac'] | ||
| addr = ip_address(unicode(intf['addr'])) | ||
| if addr.version == 4: | ||
| selected_port_facts[key + '_router_ipv4'] = intf['addr'] | ||
| selected_port_facts[key + '_host_ipv4'] = intf['peer_addr'] | ||
| selected_port_facts[key + '_host_mac'] = switch_arptable['arptable']['v4'][intf['peer_addr']]['macaddress'] | ||
| elif addr.version == 6: | ||
| selected_port_facts[key + '_router_ipv6'] = intf['addr'] | ||
| selected_port_facts[key + '_host_ipv6'] = intf['peer_addr'] | ||
| if up_port: | ||
| logger.info("{} port is {}".format(key, up_port)) | ||
| break | ||
| return up_port, selected_port_facts | ||
|
|
||
| @pytest.fixture(scope='function') | ||
| def gather_facts(tbinfo, duthosts, enum_rand_one_per_hwsku_frontend_hostname): | ||
| duthost = duthosts[enum_rand_one_per_hwsku_frontend_hostname] | ||
| facts = {} | ||
|
|
||
| logger.info("Gathering facts on DUT ...") | ||
| mg_facts = duthost.get_extended_minigraph_facts(tbinfo) | ||
|
|
||
| # Use the arp table to get the mac address of the host (VM's) instead of lldp_facts as that is was is used | ||
| # by the DUT to forward traffic - regardless of lag or port. | ||
| switch_arptable = duthost.switch_arptable()['ansible_facts'] | ||
| used_intfs = set() | ||
| src = None # Name of lag or interface that is is up | ||
| dst = None # Name of lag or interface that is is up | ||
|
|
||
| # if minigraph_portchannel_interfaces is not empty - topology with lag - check if we have 2 lags that are 'Up' | ||
| if mg_facts['minigraph_portchannel_interfaces']: | ||
| # Get lag facts from the DUT to check which ag is up | ||
| lag_facts = duthost.lag_facts(host=duthost.hostname)['ansible_facts']['lag_facts'] | ||
| src, src_lag_facts = get_lag_facts(duthost, lag_facts, switch_arptable, mg_facts, used_intfs, key='src') | ||
| used_intfs.add(src) | ||
| if src: | ||
| facts.update(src_lag_facts) | ||
| # We found a src lag, let see if we can find a dst lag | ||
| dst, dst_lag_facts = get_lag_facts(duthost, lag_facts, switch_arptable, mg_facts, used_intfs, key='dst') | ||
| used_intfs.add(dst) | ||
| facts.update(dst_lag_facts) | ||
|
|
||
| if src is None or dst is None: | ||
| # We didn't find 2 lags, lets check up interfaces | ||
| port_status = duthost.show_interface(command='status')['ansible_facts'] | ||
| if src is None: | ||
| src, src_port_facts = get_port_facts(duthost, mg_facts, port_status, switch_arptable, used_intfs, key='src') | ||
| used_intfs.add(src) | ||
| facts.update(src_port_facts) | ||
|
|
||
| if dst is None: | ||
| dst, dst_port_facts = get_port_facts(duthost, mg_facts, port_status, switch_arptable, used_intfs, key='dst') | ||
| facts.update(dst_port_facts) | ||
|
|
||
| if src is None or dst is None: | ||
| pytest.fail("Did not find 2 lag or interfaces that are up on host {}".duthost.hostname) | ||
| logger.info("gathered_new_facts={}".format(json.dumps(facts, indent=2))) | ||
|
|
||
| yield facts |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters