Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:13263] Fix mux simulator post #13271

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

mssonicbld
Copy link
Collaborator

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Fix the ValueError for mux simulator utilities:

08:21:52 mux_simulator_control._post L0196 WARNING| POST http://10.64.*.*:8082/mux/vms21-6 with data {'active_side': 'lower_tor'} failed, err: ValueError('Function has keyword-only parameters or annotations, use inspect.signature() API which can support them')

Signed-off-by: Longxiang Lyu [email protected]

How did you do it?

Use inspect.signature instead.

How did you verify/test it?

Run over dualtor testbed.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

What is the motivation for this PR?
Fix the ValueError for mux simulator utilities:

08:21:52 mux_simulator_control._post              L0196 WARNING| POST http://10.64.*.*:8082/mux/vms21-6 with data {'active_side': 'lower_tor'} failed, err: ValueError('Function has keyword-only parameters or annotations, use inspect.signature() API which can support them')

How did you do it?
Use inspect.signature instead.

How did you verify/test it?
Run over dualtor testbed.

Signed-off-by: Longxiang Lyu <[email protected]>
@mssonicbld mssonicbld mentioned this pull request Jun 13, 2024
8 tasks
@mssonicbld
Copy link
Collaborator Author

Original PR: #13263

@mssonicbld mssonicbld merged commit 3265b07 into sonic-net:202311 Jun 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants