Fix mux simulator post #13263
Merged
Fix mux simulator post #13263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Longxiang Lyu <[email protected]>
wangxin
approved these changes
Jun 13, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jun 13, 2024
What is the motivation for this PR? Fix the ValueError for mux simulator utilities: 08:21:52 mux_simulator_control._post L0196 WARNING| POST http://10.64.*.*:8082/mux/vms21-6 with data {'active_side': 'lower_tor'} failed, err: ValueError('Function has keyword-only parameters or annotations, use inspect.signature() API which can support them') How did you do it? Use inspect.signature instead. How did you verify/test it? Run over dualtor testbed. Signed-off-by: Longxiang Lyu <[email protected]>
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jun 13, 2024
What is the motivation for this PR? Fix the ValueError for mux simulator utilities: 08:21:52 mux_simulator_control._post L0196 WARNING| POST http://10.64.*.*:8082/mux/vms21-6 with data {'active_side': 'lower_tor'} failed, err: ValueError('Function has keyword-only parameters or annotations, use inspect.signature() API which can support them') How did you do it? Use inspect.signature instead. How did you verify/test it? Run over dualtor testbed. Signed-off-by: Longxiang Lyu <[email protected]>
|
Cherry-pick PR to 202311: #13271 |
|
Cherry-pick PR to 202305: #13272 |
This was referenced Jun 13, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jun 13, 2024
What is the motivation for this PR? Fix the ValueError for mux simulator utilities: 08:21:52 mux_simulator_control._post L0196 WARNING| POST http://10.64.*.*:8082/mux/vms21-6 with data {'active_side': 'lower_tor'} failed, err: ValueError('Function has keyword-only parameters or annotations, use inspect.signature() API which can support them') How did you do it? Use inspect.signature instead. How did you verify/test it? Run over dualtor testbed. Signed-off-by: Longxiang Lyu <[email protected]>
|
Cherry-pick PR to 202405: #13275 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jun 13, 2024
What is the motivation for this PR? Fix the ValueError for mux simulator utilities: 08:21:52 mux_simulator_control._post L0196 WARNING| POST http://10.64.*.*:8082/mux/vms21-6 with data {'active_side': 'lower_tor'} failed, err: ValueError('Function has keyword-only parameters or annotations, use inspect.signature() API which can support them') How did you do it? Use inspect.signature instead. How did you verify/test it? Run over dualtor testbed. Signed-off-by: Longxiang Lyu <[email protected]>
mssonicbld
pushed a commit
that referenced
this pull request
Jun 13, 2024
What is the motivation for this PR? Fix the ValueError for mux simulator utilities: 08:21:52 mux_simulator_control._post L0196 WARNING| POST http://10.64.*.*:8082/mux/vms21-6 with data {'active_side': 'lower_tor'} failed, err: ValueError('Function has keyword-only parameters or annotations, use inspect.signature() API which can support them') How did you do it? Use inspect.signature instead. How did you verify/test it? Run over dualtor testbed. Signed-off-by: Longxiang Lyu <[email protected]>
mssonicbld
added
Included in 202405 branch
Included in 202311 branch
and removed
Created PR to 202405 branch
labels
wangxin
pushed a commit
that referenced
this pull request
Jun 14, 2024
What is the motivation for this PR? Fix the ValueError for mux simulator utilities: 08:21:52 mux_simulator_control._post L0196 WARNING| POST http://10.64.*.*:8082/mux/vms21-6 with data {'active_side': 'lower_tor'} failed, err: ValueError('Function has keyword-only parameters or annotations, use inspect.signature() API which can support them') How did you do it? Use inspect.signature instead. How did you verify/test it? Run over dualtor testbed. Signed-off-by: Longxiang Lyu <[email protected]> Co-authored-by: Longxiang Lyu <[email protected]>
mssonicbld
added
Included in 202305 branch
and removed
Created PR to 202305 branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix the
ValueErrorfor mux simulator utilities:Signed-off-by: Longxiang Lyu [email protected]
How did you do it?
Use
inspect.signatureinstead.How did you verify/test it?
Run over dualtor testbed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation