Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accton]: Add a new supported device AS5712-54X #898

Merged
merged 4 commits into from
Aug 23, 2017
Merged

[Accton]: Add a new supported device AS5712-54X #898

merged 4 commits into from
Aug 23, 2017

Conversation

jeankuo
Copy link
Contributor

@jeankuo jeankuo commented Aug 18, 2017

Switch Vendor: Edge-core
Switch SKU: AS5712-54X
ASIC Vendor: Broadcom
Swich ASIC: TRIDENT2
Port Configuration: 48x10G+6x40G
SONiC Image: SONiC-ONIE-Broadcom

@jeankuo
[Accton]: Add a new supported device AS5712-54X
25c3e62 
Switch Vendor: Edge-core
Switch SKU: AS5712-54X
ASIC Vendor: Broadcom
Swich ASIC: TRIDENT2
Port Configuration: 48x10G+6x40G
SONiC Image: SONiC-ONIE-Broadcom
@msftclas
Copy link

@jeankuo,
Thanks for having already signed the Contribution License Agreement. Your agreement has not been validated yet. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

lguohan
lguohan reviewed Aug 18, 2017
View reviewed changes
device/accton/x86_64-accton_as5712_54x-r0/led_proc_init.soc Outdated
port xe enable=no
port xe enable=yes

m xlmac_tx_ctrl average_ipg=0xc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why you need this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I will remvoe it.

lguohan
lguohan reviewed Aug 18, 2017
View reviewed changes
device/accton/x86_64-accton_as5712_54x-r0/led_proc_init.soc Outdated
m xlmac_tx_ctrl average_ipg=0xc
# Set default interface mode for 10G SFP ports
port xe sp=10000 if=SFI
console off; port xe sp=40000 if=CR4; console on
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the link speed 40g or 10g?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 10G. I will remvoe it.

lguohan
lguohan reviewed Aug 18, 2017
View reviewed changes
device/accton/x86_64-accton_as5712_54x-r0/led_proc_init.soc Outdated
# So we need to disable all ports and then enable all ports to reset the ports s
tate.
port xe enable=no
port xe enable=yes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the init problem? sai issue, opennsl issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I will remvoe it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done to update.

@jeankuo
[Accton]: Add a new supported device AS5712-54X (Update 1)
e9dcf9f 
Switch Vendor: Edge-core
Switch SKU: AS5712-54X
ASIC Vendor: Broadcom
Swich ASIC: TRIDENT2
Port Configuration: 48x10G+6x40G
SONiC Image: SONiC-ONIE-Broadcom
jleveque
jleveque suggested changes Aug 18, 2017
View reviewed changes
Copy link
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update sfputil.py to comply with new specs, as they have recently changed (see https://github.com/Azure/SONiC/wiki/Porting-Guide for more info).

@jeankuo
[Accton]: Add a new supported device AS5712-54X (Update 2)
3325793 
Switch Vendor: Edge-core
Switch SKU: AS5712-54X
ASIC Vendor: Broadcom
Swich ASIC: TRIDENT2
Port Configuration: 48x10G+6x40G
SONiC Image: SONiC-ONIE-Broadcom
jleveque
jleveque suggested changes Aug 21, 2017
View reviewed changes
device/accton/x86_64-accton_as5712_54x-r0/Accton-AS5712-54X/port_config.ini
Ethernet68 77 tenGigE68
Ethernet69 78 tenGigE69
Ethernet70 79 tenGigE70
Ethernet71 80 tenGigE71
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add newline at EOF.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done to change.

@jeankuo
[Accton]: Add a new supported device AS5712-54X (Update 3)
bf80e0e 
Switch Vendor: Edge-core
Switch SKU: AS5712-54X
ASIC Vendor: Broadcom
Swich ASIC: TRIDENT2
Port Configuration: 48x10G+6x40G
SONiC Image: SONiC-ONIE-Broadcom
@lguohan lguohan merged commit 12ba083 into sonic-net:master Aug 23, 2017
@pollyhsu2git
Copy link
Contributor

pollyhsu2git commented Oct 16, 2017 •
edited
Loading

@stcheng, we just found that our config.bcm has not been packed within your libasibcm package, even the latest libsaibcm_3.0.3.2-5_amd64.deb (jenkins#360 built on 2017-10-15)
sonic-v2-as5712-git j_360-libsaibcm_3 0 3 2-5-pr898

stcheng pushed a commit to stcheng/sonic-buildimage that referenced this pull request May 22, 2019
[swss]: Update sonic-swss submodule
e0a00d9 
[vlan] Add pytest case to add max vlan. (sonic-net#881)
[badge]: add vs build badge (sonic-net#898)
Fix PFC watchdog not getting lossless TC (sonic-net#876)
[vstest]: skip test_AddMaxVlan as it takes almost two hours to finish (sonic-net#901)
[test]: Enforce fake port-channel interfaces carrier up

Signed-off-by: Shu0T1an ChenG <[email protected]>
@stcheng stcheng mentioned this pull request May 22, 2019
Merged
lguohan pushed a commit that referenced this pull request May 23, 2019
@lguohan
[swss]: Update sonic-swss submodule (#2935)
9331d21 
[vlan] Add pytest case to add max vlan. (#881)
[badge]: add vs build badge (#898)
Fix PFC watchdog not getting lossless TC (#876)
[vstest]: skip test_AddMaxVlan as it takes almost two hours to finish (#901)
[test]: Enforce fake port-channel interfaces carrier up

Signed-off-by: Shu0T1an ChenG <[email protected]>
MichelMoriniaux pushed a commit to criteo-forks/sonic-buildimage that referenced this pull request May 28, 2019
@MichelMoriniaux
[swss]: Update sonic-swss submodule (sonic-net#2935)
a2940ec 
[vlan] Add pytest case to add max vlan. (sonic-net#881)
[badge]: add vs build badge (sonic-net#898)
Fix PFC watchdog not getting lossless TC (sonic-net#876)
[vstest]: skip test_AddMaxVlan as it takes almost two hours to finish (sonic-net#901)
[test]: Enforce fake port-channel interfaces carrier up

Signed-off-by: Shu0T1an ChenG <[email protected]>
zhenggen-xu pushed a commit to zhenggen-xu/sonic-buildimage that referenced this pull request Oct 17, 2019
Merge remote-tracking branch 'msft_github/master'
5bf7c5e 
* msft_github/master:
  [snmpagent]: Update sonic-snmpagent submodule (sonic-net#1004)
  [swss]: Update the ipinip.j2 template to specify the IPv4 loopback address (sonic-net#998)
  Change all port_config.ini column headers from 'port' to 'index' (sonic-net#1001)
  [docker-platform-monitor]: Remove stale fancontrol.pid file (if exists) before starting fancontrol (sonic-net#1002)
  [swss]: Update swss/common submodules (sonic-net#988)
  [snmp]: Update py-swsssdk/snmpagent submodules (sonic-net#996)
  [Broadcom]: Update SAI version to 3.0.3.2-5 (sonic-net#997)
  [Mellanox]: Update outdated MSN2410 minigraph (sonic-net#995)
  Add time stamp suffix to the dirty images version string (sonic-net#958)
  [Mellanox]: Remove FW upgrade procedure in docker (sonic-net#989)
  [snmp]: Update sonic-snmpagent submodule (sonic-net#986)
  [Broadcom]: Update SAI version to 3.0.3.2-4 (sonic-net#983)
  [Ingrasys]: Add Ingrasys S8900-64XC sfputil function and update submodule (sonic-net#984)
  [mellanox]: Update Mellanox SAI version (sonic-net#979)
  [Ingrasys]: Change hwmon kernel modules installation order (sonic-net#980)
  [Makefile] Allowing interactive session with the slave docker-container (sonic-net#903)
  [snmp]: Update sonic-snmpagent submodule (sonic-net#978)
  Disable snmpd module disk_hw, so no syslog messages about unavailable disks (sonic-net#977)
  [teamd]: Remove deprecated blocking logic before starting teamd (sonic-net#976)
  [Broadcom]: Update libsai version to 3.0.3.2-2 (sonic-net#973)
  [device/accton]: Add a new supported device, AS7312-54X (sonic-net#955)
  [sairedis]: update sairedis submodule (sonic-net#974)
  lacp runner will send lacp update right after it received SIGINT (sonic-net#969)
  [config]: Fix management interface configuration (sonic-net#966)
  [Broadcom]: Update OpenNSL modules (sonic-net#970)
  [utilities]: Update sonic-utilities (sonic-net#968)
  [interfaces]: Change MTU value to 9100  (sonic-net#967)
  Framework to plugin Organization specific scripts during ONIE Image build  (sonic-net#951)
  Always start with Forwarding State flag set for bgpd (sonic-net#963)
  Update sonic-utilities to be compatible with sonic-net#942 (sonic-net#965)
  [swss]: Fix the command to get HWSKU with sonic-cfggen (sonic-net#964)
  [bgp]: Fix the deployment_id with DEVICE_METADATA (sonic-net#962)
  [Ingrasys] Update Ingrasys submodule for S8900-54XC (sonic-net#954)
  [build/onie installer] Install grub for SONiC post migration from another NOS (sonic-net#949)
  [syncd]: Comment out unused docker-ptf-brcm.mk
  [Broadcom]: Update OpenNSL/SAI version (sonic-net#959)
  [swss]: Move swss/common/sairedis submodule to 201709 tag
  [sairedis]: update sairedis submodule head (sonic-net#956)
  [service template] Starting new docker when HWSKU change is detected (sonic-net#946)
  [config] Fix an issue that bgp asn data type is not consistent (sonic-net#953)
  [mellanox]: Update Mellanox SAI version ansd SDK version
  [Ingrasys] update port_config.ini and sfputil for ingrasys platforms (sonic-net#952)
  [frr]: RR client support in minigraph for FRR (sonic-net#923)
  [configdb] Migrate minigraph configurations to DB (sonic-net#942)
  [devices]: Add led plugin for Arista 7060CX-32S and 7260CX3-64 (sonic-net#945)
  [sonic-slave]: SLAVE_TAG should be for both Dockerfile and Dockerfile.user (sonic-net#950)
  [github]: add templates for submitting issues and PR (sonic-net#947)
  [rsyslog]: Use timegenerated instead of timestamp (sonic-net#944)
  [dell]: remove nos_to_sonic_grub.cfg (sonic-net#943)
  [slave.mk]: Apply series of patches to SONIC_PYTHON_STDEB_DEBS targets if they exist (sonic-net#941)
  [rsyslog]: Use SONiC template in containers (sonic-net#940)
  [Broadcom]: Remove BRCM_OPENNSL library and upgrade BRCM_SAI to 3.0.3.2 (sonic-net#938)
  [baseimage]: allocate varlog disk in the initramfs stage (sonic-net#936)
  [sairedis]: revert deadlock fix in sonic-sairedis submodule (sonic-net#934)
  Replace CRLF line endings with LF (sonic-net#932)
  Fix confusing comment (sonic-net#931)
  Update sfputil support for Ingrasys S9100 (sonic-net#929)
  [quagga]: Disable ipv4 over ipv6 and enable ipv6 over ipv4 peer group (sonic-net#922)
  [quagga] enable core dump for bgpd and zebra (sonic-net#927)
  [devices]: Update Dell s6100/z9100 platform modules (sonic-net#925)
  Revert "Migrate DEVICE_METADATA to db (sonic-net#919)" (sonic-net#928)
  Migrate DEVICE_METADATA to db (sonic-net#919)
  [devices]: Bump sonic-platform-modules-arista submodule (sonic-net#924)
  [image]: build sonic-broadcom.raw image for sonic conversion from ftos (sonic-net#901)
  [sonic-slave] Force pyangbind version to 0.5.10 (sonic-net#918)
  [Arista-7260CX3] Rename hwSKU Arista-7260CX3-64 to Arista-7260CX3-C64, introducing new hwSKU Arista-7260CX3-D108C8 (sonic-net#920)
  [devices]: modify sfputil plugins for mellanox devices for new platform API (sonic-net#916)
  [cavm]Update sai revision and packet driver (sonic-net#914)
  [translate-acl] Specify pyangbind version to not introduce new dependency (sonic-net#915)
  Update sfputil support for Arista platforms (sonic-net#912)
  Port speed (sonic-net#879)
  [Accton]: Add a new supported device AS5712-54X (sonic-net#898)
  [kernel]: update kernel submodule (sonic-net#910)
  [device]: Updated dell s6100 submodule to 5ab014 (sonic-net#909)
  [broadcom]: update broadcom sai package to 2.1.5.1-17 (sonic-net#908)
  IPv4 prefixes shouldn't be sent by default over IPv6 session with FRR. (sonic-net#905)
  [submodule]: update sonic linux kernel (sonic-net#906)
  [sonic-sairedis] update sairedis submodule (sonic-net#211, sonic-net#212) (sonic-net#904)
  [mlnx-fw-upgrade]: Define required FW version in build time. (sonic-net#902)
  [SAI]: Remove the SAI submodule from buildimage repo (sonic-net#893)
  [Submodule update]: sonic-utilities (sonic-net#888)
  Revert "[mellanox]: Update Mellanox SAI version"
  [mellanox]: Update Mellanox SAI version
  [utilities]: Update sonic-utilities submodule
  [swss-common]: Update sonic-swss-common submodule
  [mellanox]: Disable fsat boot mode for SX kernel
  [quagga]: Update sonic-quagga submodule
  [Broadcom]: Update Broadcom SAI/SDK version (sonic-net#883)
  Squash merge v1.0.3 branch onto master
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020
@lguohan
[badge]: add vs build badge (sonic-net#898)
b0ad3eb 
remove build badge for cavium and p4
@judyjoseph judyjoseph mentioned this pull request May 3, 2020
Merged
lguohan pushed a commit that referenced this pull request May 4, 2020
@judyjoseph
[submodule]: advance sonic-utilities submodule (#4523)
e8748eb 
c2facd8 [show] Fix abbreviations for 'show ip bgp ...' commands (#901)
cb68e7d Add support for multi-ASIC devices (#877)
44ed6e9 Improved route_check tool and adopt to 20191130 image. (#898)
6fba8db [psushow] Add a column to display LED color to show platform psustatus output (#886)
e747456 ssd_mitigation_changes (#829)
rlhui added a commit that referenced this pull request May 10, 2020
@rlhui
Added the below PRs:
87f3592 
[Vnet] Fix NameError for 'swsssdk' and align output (#902)
[config] Add 'interface transceiver' subgroup with 'lpmode' and 'reset' subcommands (#904)
Improved route_check tool and adopt to 20191130 image. (#898)
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 10, 2021
@renukamanavalan
Improved route_check tool and adopt to 20191130 image. (sonic-net#898)
44ed6e9 
* Changes:
1) Add syslog support.
2) Enable forever periodic scan
3) Skip link local addresses
4) Skip eth0 routes
3) Adopt to 20191130 changes
    3.1) APPl-DB INTF_TABLE may not have IP address
    3.2) nexthop is never empty

* No logical code change. A small name change.

* 1) Adopt to 201811 -- Filter out 'lo' & 'docker0' in addition to 'eth0' as local routes
2) Ensure to read route entry w/o prefix, if not present with prefix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

@jleveque jleveque jleveque approved these changes

Assignees
No one assigned
Labels
Enhancement ➕
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeankuo @msftclas @pollyhsu2git @lguohan @jleveque