[service template] Starting new docker when HWSKU change is detected #946

yxieca · 2017-09-08T22:56:08Z

Existing dockers has paths mounted according to the HWSKU. When HWSKU
changes, these dockers need to be destroyed and recreated with the
correct paths mounted.

msftclas · 2017-09-08T22:56:12Z

@yxieca,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

stcheng · 2017-09-08T23:45:42Z

@zhenggen-xu do you need this feature? could you also take a look at this pull request?

lguohan · 2017-09-09T01:19:11Z

files/build_templates/docker_image_ctl.j2

    fi
+
+	echo "Starting new {{docker_container_name}} docker with HWSKU $HWSKU"


[](start = 0, length = 1)

use whitespaces instead of tab

Thanks for catching this. Fixed now.

lguohan · 2017-09-09T01:27:40Z

files/build_templates/docker_image_ctl.j2

-    else
+        exit 0
+{%- else %}
+        dkrSku=`docker inspect --type container {{docker_container_name}} | python -c "import sys, json, os; print os.path.basename([x for x in json.load(sys.stdin)[0]['Mounts'] if x['Destination'] == '/usr/share/sonic/hwsku'][0]['Source'])"`


docker inspect --type container {{docker_container_name}} [](start = 16, length = 57)

can you combine this with line 8 so that you do not need to inspect twice?

That makes sense. I've changed the code so there is only one docker inspect call.

They needs to be two statements, because the outer if only needs to test the result from docker inspection result, it doesn't need to see the python error if there is any.

Regards,
Ying

lguohan · 2017-09-09T01:33:23Z

files/build_templates/docker_image_ctl.j2

@@ -7,18 +7,32 @@ HWSKU=`sonic-cfggen -m /etc/sonic/minigraph.xml -v minigraph_hwsku`
 start() {
    docker inspect --type container {{docker_container_name}} &>/dev/null
    if [ "$?" -eq "0" ]; then
+{%- if docker_container_name == "database" %}


why do you want to treat database differently? if database is hwsku independent, then we should not mount the hwsku directory into database.

Taoyu has a change to remove that mounting. He said he will take care of that change after my change went in.

but, you do not really need to treat database docker differently, right?

Please see the conversation in the next comments.

Thanks,
Ying

lguohan · 2017-09-09T01:34:35Z

files/build_templates/docker_image_ctl.j2

+        exit 0
+{%- else %}
+        dkrSku=`docker inspect --type container {{docker_container_name}} | python -c "import sys, json, os; print os.path.basename([x for x in json.load(sys.stdin)[0]['Mounts'] if x['Destination'] == '/usr/share/sonic/hwsku'][0]['Source'])"`
+        if [ "$dkrSku" == "$HWSKU" ]; then


what does dkr stand for?

docker, I'll use a longer name.

lguohan

as comments.

zhenggen-xu · 2017-09-09T03:26:50Z

files/build_templates/docker_image_ctl.j2

@@ -7,18 +7,32 @@ HWSKU=`sonic-cfggen -m /etc/sonic/minigraph.xml -v minigraph_hwsku`
 start() {
    docker inspect --type container {{docker_container_name}} &>/dev/null
    if [ "$?" -eq "0" ]; then
+{%- if docker_container_name == "database" %}


Is is necessary to distinguish the database container here?
I understand database container might be agnostic to HWSKU, but the container would have a wrong hwsku path inside. On the other hand, if we want to save some time for bootup, there are more containers that are HWSKU agnostic.

You are absolutely right.

The mounting will be removed by Taoyu. His change is already in review. So I didn't duplicate the change. He will have to do a merge after my change went in.

with or not to moun hswku into database docker is a separate issue, that will be addressed by taoyu. I get that. But, for you change, I think you do not need to treat database docker differently with or ot the hwsku is mounted. You do not need to add database specific logic here.

I chatted with Taoyu.

Basically, once we move to config_db, we won't be able to get HWSKU at the time when database container is starting.

If I include Taoyu's logic of not getting HWSKU and not mounting HWSKU into database container, will you be ok with this change?

Can you take a look at the latest change to see if you like it or not?

With this change, I included Taoyu's logic, not mounting hwsku in database container.

Thanks,
Ying

lguohan · 2017-09-12T17:03:21Z

files/build_templates/docker_image_ctl.j2

+        exit 0
+{%- else %}
+        DOCKERMOUNT=`echo $DOCKERCHECK | python -c "import sys, json, os; print os.path.basename([x for x in json.load(sys.stdin)[0]['Mounts'] if x['Destination'] == '/usr/share/sonic/hwsku'][0]['Source'])" 2>/dev/null`
+        if [ "$DOCKERMOUNT" == "$HWSKU" ]; then


for database, the hwsku is not mounted, then if there is no dockermount let's do docker start then. In this case, you do no need to treat database specially.

Change has been made according to our conversations.

The change here so far has been tested. If you are ok with it. I'll rebase on top of Taoyu's change and run another test before checking in.

Thanks,
Ying

lguohan · 2017-09-13T05:52:49Z

can you resolve the conflict?

Existing dockers has paths mounted according to the HWSKU. When HWSKU changes, these dockers need to be destroyed and recreated with the correct paths mounted.

swss: [vxlanorch]: Allow ipv6 src ip for Vxlan tunnel creation (sonic-net#896) [aclorch]: Allow DTEL drop actions in DTEL flow watchlist (sonic-net#915) Fix typo in orchagent_restart_check from fasle to false. (sonic-net#923) [sonic-swss]: Fix for FPM accept call failure in ARM arch (sonic-net#925) Add retryCount option for orchagent_restart_check program. (sonic-net#833) [vlan] Add pytest cases to validate nonexistent vlan behavior. (sonic-net#874) [intfsorch] Wait for interface prior to prefix (sonic-net#796) Set timer only when interval changes. Not in each firing of the timer. (sonic-net#945) [test]: Fix set interface in configuration database (sonic-net#956) [copporch]: Fix polymorphic type error (sonic-net#946) [AclOrch]: Fix the acl mirror counter doubled by inactive mirror and active again (sonic-net#952) [MirrorOrch]: Init the next hop ip with 0 instead of default constructor (sonic-net#953) [portsorch]: Add reference count of port (sonic-net#962) [mock_test]: Move mock tests into a separate folder to separate them from vs tests (sonic-net#950) remove crm acl_counters when acl_table removed (sonic-net#918) [aclorch]: Fix matching MIRROR_DSCP throws unnecessary errors (sonic-net#966) [policerorch]: Fix return code comparison error (sonic-net#968) [gitignore]: Add swss-dbg related files (sonic-net#967) [vxlanmgrd]: Fix for vxlanmgrd cannot correctly work after config reload (sonic-net#934) [vxlanorch]: Add extra info into NOTICE logs (sonic-net#891) [test]: Add a neighbor entry with BCAST MAC and verify its ignored (sonic-net#955) [copporch]: Fix copporch in DEL command (sonic-net#972) [orchagent]: Fix crash during orchagent process exit (sonic-net#974) [vnetorch]: Fix VNET orchagents order for warm-reboot flow (sonic-net#958) [test]: Skip unstable test test_vnet_orch_1 (sonic-net#976) [intfsorch]: Fix rif flex counter removal error (sonic-net#975) Update tests README.md file [aclorch]: Change CFG_ACL_TABLE_NAME to CFG_ACL_TABLE_TABLE_NAME (sonic-net#978) [test]: Skip test_watermark.py::TestWatermark::test_lua_plugins (sonic-net#981) [teamsyncd]: Add information for LAG membership changes (sonic-net#982) common: Add an assert to logger, which will log a message and abort. (sonic-net#286) [test]: Add IpAddress::isZero() unit test (sonic-net#289) do not abort when read timerfd return 0 and errno = 0 (sonic-net#291) Add BGP_STATE_TABLE in stateDB (sonic-net#273) [IpAddress]: add mcast scope on address and isFullMask method on prefix (sonic-net#285) Add ignore Wshadow pragma to json.hpp (sonic-net#292) [executor]: Fix Executor does not get correct priority saved in m_selectable (sonic-net#290) [schema]: Remove duplicate STATE_MIRROR_SESSION_TABLE_NAME (sonic-net#294) timerfd:read failure - Record in logs as error. (sonic-net#295) [schema]: Change CFG_ACL_TABLE_NAME to CFG_ACL_TABLE_TABLE_NAME (sonic-net#296) [schema]: Add PASS_THROUGH_ROUTE_TABLE to config and application db (sonic-net#297) sairedis: ARM32 bit fixes, for 64bit printf format specifier (sonic-net#468) Reduce the timeout (GET_RESPONSE_TIMEOUT) from 6 minutes to 1 minute. (sonic-net#472) Fixed config_syncd_barefoot function (sonic-net#474) [syncd_init_common.sh] fix fast reboot backwards compatibility (sonic-net#480) Add default bridge id for bridge port id of type PORT in virtual switch (sonic-net#473) Fix a bug in parsing kernel argument of fast-reboot (sonic-net#482) Add TimerWatchdog for monitoring long execution apis (sonic-net#469) Add specific comparison logic for tunnel map (sonic-net#475) [vslib] add ACL action capabilities support (sonic-net#481) Per buffer pool watermark polling mode (sonic-net#485) Add specific comparison logic for ACL counter (sonic-net#484) Process flex counters requests in separate thread (sonic-net#483) Make sairedis/syncd synchronous (sonic-net#476) Fixed conditional operator. (sonic-net#487) Signed-off-by: Shu0T1an ChenG <[email protected]>

swss: [vxlanorch]: Allow ipv6 src ip for Vxlan tunnel creation (#896) [aclorch]: Allow DTEL drop actions in DTEL flow watchlist (#915) Fix typo in orchagent_restart_check from fasle to false. (#923) [sonic-swss]: Fix for FPM accept call failure in ARM arch (#925) Add retryCount option for orchagent_restart_check program. (#833) [vlan] Add pytest cases to validate nonexistent vlan behavior. (#874) [intfsorch] Wait for interface prior to prefix (#796) Set timer only when interval changes. Not in each firing of the timer. (#945) [test]: Fix set interface in configuration database (#956) [copporch]: Fix polymorphic type error (#946) [AclOrch]: Fix the acl mirror counter doubled by inactive mirror and active again (#952) [MirrorOrch]: Init the next hop ip with 0 instead of default constructor (#953) [portsorch]: Add reference count of port (#962) [mock_test]: Move mock tests into a separate folder to separate them from vs tests (#950) remove crm acl_counters when acl_table removed (#918) [aclorch]: Fix matching MIRROR_DSCP throws unnecessary errors (#966) [policerorch]: Fix return code comparison error (#968) [gitignore]: Add swss-dbg related files (#967) [vxlanmgrd]: Fix for vxlanmgrd cannot correctly work after config reload (#934) [vxlanorch]: Add extra info into NOTICE logs (#891) [test]: Add a neighbor entry with BCAST MAC and verify its ignored (#955) [copporch]: Fix copporch in DEL command (#972) [orchagent]: Fix crash during orchagent process exit (#974) [vnetorch]: Fix VNET orchagents order for warm-reboot flow (#958) [test]: Skip unstable test test_vnet_orch_1 (#976) [intfsorch]: Fix rif flex counter removal error (#975) Update tests README.md file [aclorch]: Change CFG_ACL_TABLE_NAME to CFG_ACL_TABLE_TABLE_NAME (#978) [test]: Skip test_watermark.py::TestWatermark::test_lua_plugins (#981) [teamsyncd]: Add information for LAG membership changes (#982) common: Add an assert to logger, which will log a message and abort. (#286) [test]: Add IpAddress::isZero() unit test (#289) do not abort when read timerfd return 0 and errno = 0 (#291) Add BGP_STATE_TABLE in stateDB (#273) [IpAddress]: add mcast scope on address and isFullMask method on prefix (#285) Add ignore Wshadow pragma to json.hpp (#292) [executor]: Fix Executor does not get correct priority saved in m_selectable (#290) [schema]: Remove duplicate STATE_MIRROR_SESSION_TABLE_NAME (#294) timerfd:read failure - Record in logs as error. (#295) [schema]: Change CFG_ACL_TABLE_NAME to CFG_ACL_TABLE_TABLE_NAME (#296) [schema]: Add PASS_THROUGH_ROUTE_TABLE to config and application db (#297) sairedis: ARM32 bit fixes, for 64bit printf format specifier (#468) Reduce the timeout (GET_RESPONSE_TIMEOUT) from 6 minutes to 1 minute. (#472) Fixed config_syncd_barefoot function (#474) [syncd_init_common.sh] fix fast reboot backwards compatibility (#480) Add default bridge id for bridge port id of type PORT in virtual switch (#473) Fix a bug in parsing kernel argument of fast-reboot (#482) Add TimerWatchdog for monitoring long execution apis (#469) Add specific comparison logic for tunnel map (#475) [vslib] add ACL action capabilities support (#481) Per buffer pool watermark polling mode (#485) Add specific comparison logic for ACL counter (#484) Process flex counters requests in separate thread (#483) Make sairedis/syncd synchronous (#476) Fixed conditional operator. (#487) Signed-off-by: Shu0T1an ChenG <[email protected]>

* msft_github/master: [snmpagent]: Update sonic-snmpagent submodule (sonic-net#1004) [swss]: Update the ipinip.j2 template to specify the IPv4 loopback address (sonic-net#998) Change all port_config.ini column headers from 'port' to 'index' (sonic-net#1001) [docker-platform-monitor]: Remove stale fancontrol.pid file (if exists) before starting fancontrol (sonic-net#1002) [swss]: Update swss/common submodules (sonic-net#988) [snmp]: Update py-swsssdk/snmpagent submodules (sonic-net#996) [Broadcom]: Update SAI version to 3.0.3.2-5 (sonic-net#997) [Mellanox]: Update outdated MSN2410 minigraph (sonic-net#995) Add time stamp suffix to the dirty images version string (sonic-net#958) [Mellanox]: Remove FW upgrade procedure in docker (sonic-net#989) [snmp]: Update sonic-snmpagent submodule (sonic-net#986) [Broadcom]: Update SAI version to 3.0.3.2-4 (sonic-net#983) [Ingrasys]: Add Ingrasys S8900-64XC sfputil function and update submodule (sonic-net#984) [mellanox]: Update Mellanox SAI version (sonic-net#979) [Ingrasys]: Change hwmon kernel modules installation order (sonic-net#980) [Makefile] Allowing interactive session with the slave docker-container (sonic-net#903) [snmp]: Update sonic-snmpagent submodule (sonic-net#978) Disable snmpd module disk_hw, so no syslog messages about unavailable disks (sonic-net#977) [teamd]: Remove deprecated blocking logic before starting teamd (sonic-net#976) [Broadcom]: Update libsai version to 3.0.3.2-2 (sonic-net#973) [device/accton]: Add a new supported device, AS7312-54X (sonic-net#955) [sairedis]: update sairedis submodule (sonic-net#974) lacp runner will send lacp update right after it received SIGINT (sonic-net#969) [config]: Fix management interface configuration (sonic-net#966) [Broadcom]: Update OpenNSL modules (sonic-net#970) [utilities]: Update sonic-utilities (sonic-net#968) [interfaces]: Change MTU value to 9100 (sonic-net#967) Framework to plugin Organization specific scripts during ONIE Image build (sonic-net#951) Always start with Forwarding State flag set for bgpd (sonic-net#963) Update sonic-utilities to be compatible with sonic-net#942 (sonic-net#965) [swss]: Fix the command to get HWSKU with sonic-cfggen (sonic-net#964) [bgp]: Fix the deployment_id with DEVICE_METADATA (sonic-net#962) [Ingrasys] Update Ingrasys submodule for S8900-54XC (sonic-net#954) [build/onie installer] Install grub for SONiC post migration from another NOS (sonic-net#949) [syncd]: Comment out unused docker-ptf-brcm.mk [Broadcom]: Update OpenNSL/SAI version (sonic-net#959) [swss]: Move swss/common/sairedis submodule to 201709 tag [sairedis]: update sairedis submodule head (sonic-net#956) [service template] Starting new docker when HWSKU change is detected (sonic-net#946) [config] Fix an issue that bgp asn data type is not consistent (sonic-net#953) [mellanox]: Update Mellanox SAI version ansd SDK version [Ingrasys] update port_config.ini and sfputil for ingrasys platforms (sonic-net#952) [frr]: RR client support in minigraph for FRR (sonic-net#923) [configdb] Migrate minigraph configurations to DB (sonic-net#942) [devices]: Add led plugin for Arista 7060CX-32S and 7260CX3-64 (sonic-net#945) [sonic-slave]: SLAVE_TAG should be for both Dockerfile and Dockerfile.user (sonic-net#950) [github]: add templates for submitting issues and PR (sonic-net#947) [rsyslog]: Use timegenerated instead of timestamp (sonic-net#944) [dell]: remove nos_to_sonic_grub.cfg (sonic-net#943) [slave.mk]: Apply series of patches to SONIC_PYTHON_STDEB_DEBS targets if they exist (sonic-net#941) [rsyslog]: Use SONiC template in containers (sonic-net#940) [Broadcom]: Remove BRCM_OPENNSL library and upgrade BRCM_SAI to 3.0.3.2 (sonic-net#938) [baseimage]: allocate varlog disk in the initramfs stage (sonic-net#936) [sairedis]: revert deadlock fix in sonic-sairedis submodule (sonic-net#934) Replace CRLF line endings with LF (sonic-net#932) Fix confusing comment (sonic-net#931) Update sfputil support for Ingrasys S9100 (sonic-net#929) [quagga]: Disable ipv4 over ipv6 and enable ipv6 over ipv4 peer group (sonic-net#922) [quagga] enable core dump for bgpd and zebra (sonic-net#927) [devices]: Update Dell s6100/z9100 platform modules (sonic-net#925) Revert "Migrate DEVICE_METADATA to db (sonic-net#919)" (sonic-net#928) Migrate DEVICE_METADATA to db (sonic-net#919) [devices]: Bump sonic-platform-modules-arista submodule (sonic-net#924) [image]: build sonic-broadcom.raw image for sonic conversion from ftos (sonic-net#901) [sonic-slave] Force pyangbind version to 0.5.10 (sonic-net#918) [Arista-7260CX3] Rename hwSKU Arista-7260CX3-64 to Arista-7260CX3-C64, introducing new hwSKU Arista-7260CX3-D108C8 (sonic-net#920) [devices]: modify sfputil plugins for mellanox devices for new platform API (sonic-net#916) [cavm]Update sai revision and packet driver (sonic-net#914) [translate-acl] Specify pyangbind version to not introduce new dependency (sonic-net#915) Update sfputil support for Arista platforms (sonic-net#912) Port speed (sonic-net#879) [Accton]: Add a new supported device AS5712-54X (sonic-net#898) [kernel]: update kernel submodule (sonic-net#910) [device]: Updated dell s6100 submodule to 5ab014 (sonic-net#909) [broadcom]: update broadcom sai package to 2.1.5.1-17 (sonic-net#908) IPv4 prefixes shouldn't be sent by default over IPv6 session with FRR. (sonic-net#905) [submodule]: update sonic linux kernel (sonic-net#906) [sonic-sairedis] update sairedis submodule (sonic-net#211, sonic-net#212) (sonic-net#904) [mlnx-fw-upgrade]: Define required FW version in build time. (sonic-net#902) [SAI]: Remove the SAI submodule from buildimage repo (sonic-net#893) [Submodule update]: sonic-utilities (sonic-net#888) Revert "[mellanox]: Update Mellanox SAI version" [mellanox]: Update Mellanox SAI version [utilities]: Update sonic-utilities submodule [swss-common]: Update sonic-swss-common submodule [mellanox]: Disable fsat boot mode for SX kernel [quagga]: Update sonic-quagga submodule [Broadcom]: Update Broadcom SAI/SDK version (sonic-net#883) Squash merge v1.0.3 branch onto master

copporch.cpp: In member function ‘virtual void CoppOrch::doTask(Consumer&)’: copporch.cpp:607:34: error: catching polymorphic type ‘const class std::out_of_range’ by value [-Werror=catch-value=] catch(const out_of_range e) ^ cc1plus: all warnings being treated as errors Signed-off-by: Shu0T1an ChenG <[email protected]>

Sonic-swss-common: [schema.h] Add trap flow counter support (#534) (sonic-net/sonic-swss-common@31f4253) [schema] Add CBF table names (#525) (sonic-net/sonic-swss-common@b15e08d) Sonic-sairedis: [cbf] Add Class Based Forwarding support (#909) sonic-net/sonic-sairedis@ecb95a8 [azp] Enable pretty code coverage results xml (#946) sonic-net/sonic-sairedis@1148d16 [gearbox] startup gbsyncd in sync mode in vSonic (#939) sonic-net/sonic-sairedis@e59a085 [unittest] Add more Meta tests (#948) sonic-net/sonic-sairedis@812f7a5 [syncd] Fix SwitchNotifications to be const reference (#945) sonic-net/sonic-sairedis@5863ed3 [syncd] Refactor syncd request shutdown command line parser (#944) sonic-net/sonic-sairedis@d598dea [unittest] Update meta tests (#943) sonic-net/sonic-sairedis@26b2237 [ci]: Support code diff coverage (#934) sonic-net/sonic-sairedis@e545b17 Sonic sairedis changes for SAI SRV6 and SAI refpoint update to v1.9.0 (#937) sonic-net/sonic-sairedis@921cf0b [sairedis] Fail get/clear api on objects created in init view mode (#930) sonic-net/sonic-sairedis@362b34e [vslib]: Remove invalid lane when create ports (#938) sonic-net/sonic-sairedis@db403f4 [Barefoot] enable bulk api`s in SAI (#927) sonic-net/sonic-sairedis@6df04d8 [unittest] Add NotificationBfdSessionStateChange tests (#940) sonic-net/sonic-sairedis@89d639b [azp] Skip auto generated saimetadata lib code coverage (#935) sonic-net/sonic-sairedis@40e9c74 Remove tail white spaces sonic-net/sonic-sairedis@dabd1a7 Bring back pyext in Makefile.am sonic-net/sonic-sairedis@94d5545 Add RedisChannel tests sonic-net/sonic-sairedis@e16606a Add RedisVidIndexGenerator tests sonic-net/sonic-sairedis@62b8fdd Add ServerConfig tests sonic-net/sonic-sairedis@58725df Add SkipRecordAttrContainer tests sonic-net/sonic-sairedis@6842d92 Update Switch tests sonic-net/sonic-sairedis@cd13f49 Add SwitchConfigContainer tests sonic-net/sonic-sairedis@6fc213d Add SwitchConfigContainer tests sonic-net/sonic-sairedis@ee24c0e Add SwitchContainer tests sonic-net/sonic-sairedis@e33c6e9 Add ZeroMQChannel tests sonic-net/sonic-sairedis@bcd1648 Add VirtualObjectIdManager tests sonic-net/sonic-sairedis@0a2cb2c [sairedis] Remove legacy allocateSwitchIndex api sonic-net/sonic-sairedis@16fff7f Sonic-swss: [orchagent] Add separate next hop table and orch (#1702) sonic-net/sonic-swss@f248e26 [portorch]: Skip to create port if the lane set isn't available in ASIC (#1923) sonic-net/sonic-swss@fd0cafe fix the type for SAI_BUFFER_PROFILE_ATTR_BUFFER_SIZE (#1942) sonic-net/sonic-swss@ef6b5d4 [cfgmgr] Fix for STATE_DB Port check (#1936) sonic-net/sonic-swss@b592ad7

…ernal branch Related work items: sonic-net#525, sonic-net#534, sonic-net#909, sonic-net#927, sonic-net#930, sonic-net#934, sonic-net#935, sonic-net#937, sonic-net#938, sonic-net#939, sonic-net#940, sonic-net#943, sonic-net#944, sonic-net#945, sonic-net#946, sonic-net#948, sonic-net#1702, sonic-net#1923, sonic-net#1936, sonic-net#1942, sonic-net#2315, sonic-net#7281, sonic-net#7375, sonic-net#8659, sonic-net#8799, sonic-net#8868, sonic-net#8875, sonic-net#8935, sonic-net#8942, sonic-net#8956, sonic-net#8961, sonic-net#8966, sonic-net#8969, sonic-net#8971, sonic-net#8978, sonic-net#8991, sonic-net#8996, sonic-net#9001, sonic-net#9008, #3146150

msftclas added the cla-not-required label Sep 8, 2017

jleveque added the Enhancement ➕ label Sep 8, 2017

lguohan reviewed Sep 9, 2017

View reviewed changes

lguohan requested changes Sep 9, 2017

View reviewed changes

zhenggen-xu reviewed Sep 9, 2017

View reviewed changes

lguohan reviewed Sep 12, 2017

View reviewed changes

lguohan approved these changes Sep 13, 2017

View reviewed changes

[service template] Starting new docker when HWSKU change is detected

2f6a473

Existing dockers has paths mounted according to the HWSKU. When HWSKU changes, these dockers need to be destroyed and recreated with the correct paths mounted.

lguohan approved these changes Sep 13, 2017

View reviewed changes

yxieca merged commit 56ae5ed into sonic-net:master Sep 14, 2017

stcheng mentioned this pull request Jul 19, 2019

[submodule]: Update swss related submodules #3190

Merged

TACappleman mentioned this pull request Oct 18, 2021

[swss-common, swss, sairedis] Update submodules #8996

Merged

AidanCopeland pushed a commit to Metaswitch/sonic-buildimage that referenced this pull request Apr 14, 2022

[azp] Enable pretty code coverage results xml (sonic-net#946)

1148d16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[service template] Starting new docker when HWSKU change is detected #946

[service template] Starting new docker when HWSKU change is detected #946

yxieca commented Sep 8, 2017

msftclas commented Sep 8, 2017

stcheng commented Sep 8, 2017

lguohan Sep 9, 2017

yxieca Sep 11, 2017

lguohan Sep 9, 2017

yxieca Sep 11, 2017

lguohan Sep 9, 2017

yxieca Sep 11, 2017

lguohan Sep 11, 2017

yxieca Sep 11, 2017

lguohan Sep 9, 2017

yxieca Sep 11, 2017

lguohan left a comment

zhenggen-xu Sep 9, 2017

yxieca Sep 11, 2017

lguohan Sep 11, 2017

yxieca Sep 11, 2017

yxieca Sep 11, 2017

lguohan Sep 12, 2017

yxieca Sep 12, 2017

lguohan commented Sep 13, 2017

		fi

		echo "Starting new {{docker_container_name}} docker with HWSKU $HWSKU"

[service template] Starting new docker when HWSKU change is detected #946

[service template] Starting new docker when HWSKU change is detected #946

Conversation

yxieca commented Sep 8, 2017

msftclas commented Sep 8, 2017

stcheng commented Sep 8, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lguohan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lguohan commented Sep 13, 2017