[caclmgrd] Remove sleep which allowed threads to progress #7475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
approved these changes
Apr 29, 2021
|
@daall: FYI: This PR should be cherry-picked to 202012 AFTER the sonic-swss-common submodule has been updated to include sonic-net/sonic-swss-common#477. |
daall
pushed a commit
that referenced
this pull request
May 10, 2021
Previously, a brief sleep was necessary in order to get Python threads to progress. The root cause of this has since been found and fixed in sonic-swss-common: sonic-net/sonic-swss-common#477. The submodule was updated here, so we can now safely remove this sleep. This PR should also be cherry-picked to the 202012 branch once the submodule is updated there to also include the fix.
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
…7475) Previously, a brief sleep was necessary in order to get Python threads to progress. The root cause of this has since been found and fixed in sonic-swss-common: sonic-net/sonic-swss-common#477. The submodule was updated here, so we can now safely remove this sleep. This PR should also be cherry-picked to the 202012 branch once the submodule is updated there to also include the fix.
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…7475) Previously, a brief sleep was necessary in order to get Python threads to progress. The root cause of this has since been found and fixed in sonic-swss-common: sonic-net/sonic-swss-common#477. The submodule was updated here, so we can now safely remove this sleep. This PR should also be cherry-picked to the 202012 branch once the submodule is updated there to also include the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Previously, a brief sleep was necessary in order to get Python threads to progress. The root cause of this has since been found and fixed in sonic-swss-common: sonic-net/sonic-swss-common#477. The submodule was updated here, so we can now safely remove this sleep.
This PR should also be cherry-picked to the 202012 branch once the submodule is updated there to also include the fix.
How to verify it
Ensure the update threads progress in caclmgrd
Which release branch to backport (provide reason below if selected)