Skip to content

Commit

Permalink
[caclmgrd] Remove sleep which allowed threads to progress (#7475)
Browse files Browse the repository at this point in the history
Previously, a brief sleep was necessary in order to get Python threads to progress. The root cause of this has since been found and fixed in sonic-swss-common: sonic-net/sonic-swss-common#477. The submodule was updated here, so we can now safely remove this sleep.

This PR should also be cherry-picked to the 202012 branch once the submodule is updated there to also include the fix.
  • Loading branch information
jleveque authored Apr 29, 2021
1 parent 963e7f4 commit 64c3d3a
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions src/sonic-host-services/scripts/caclmgrd
Original file line number Diff line number Diff line change
Expand Up @@ -646,11 +646,6 @@ class ControlPlaneAclManager(daemon_base.DaemonBase):
while True:
ctrl_plane_acl_notification = set()

# A brief sleep appears necessary in this loop or any spawned
# update threads will get stuck. Appears to be due to the sel.select() call.
# TODO: Eliminate the need for this sleep.
time.sleep(0.1)

(state, selectableObj) = sel.select(SELECT_TIMEOUT_MS)
# Continue if select is timeout or selectable object is not return
if state != swsscommon.Select.OBJECT:
Expand Down

0 comments on commit 64c3d3a

Please sign in to comment.