Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] SONiC platform daemons depend on swsscommon library #5922

Merged
merged 2 commits into from
Nov 16, 2020
Merged

[build] SONiC platform daemons depend on swsscommon library #5922

merged 2 commits into from
Nov 16, 2020

Conversation

jleveque
Copy link
Contributor

- Why I did it

To ensure proper build/installation of SONiC platform daemons (ledd, psud, syseepromd, thermalctld, xcvrd).

- How I did it

Add dependencies in appropriate makefiles

- How to verify it

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

@jleveque
Copy link
Contributor Author

@qiluo-msft: Check builds are failing because mock swsscommon calls appear to be unimplemented. Have you seen this before?

rules/sonic-psud.mk Outdated Show resolved Hide resolved
@qiluo-msft
Copy link
Collaborator

qiluo-msft commented Nov 14, 2020

I guess it is related to this part of dynamic behavior in test

try:
    from swsscommon import swsscommon
except ImportError as e:
    from tests import mock_swsscommon as swsscommon

It is not recommended practice. It assumes swsscommon is missing in unit test environment.


In reply to: 727131567 [](ancestors = 727131567)

@jleveque
Copy link
Contributor Author

jleveque commented Nov 14, 2020

I guess it is related to this part of dynamic behavior in test

try:
    from swsscommon import swsscommon
except ImportError as e:
    from tests import mock_swsscommon as swsscommon

It is not recommended practice. It assumes swsscommon is missing in unit test environment.

In reply to: 727131567 [](ancestors = 727131567)

Good find! Thanks, Qi! I believe this was recently exposed because sonic-utilities recently started depending on swsscommon, which caused to to get installed in the build environment earlier than previously.

I have opened a PR which should fix this: sonic-net/sonic-platform-daemons#112

@lguohan
Copy link
Collaborator

lguohan commented Nov 15, 2020

retest this please

@jleveque jleveque requested a review from qiluo-msft November 15, 2020 21:44
@jleveque jleveque merged commit 67dbbb3 into sonic-net:master Nov 16, 2020
@jleveque jleveque deleted the plat_daemons_swsscommon branch November 16, 2020 16:50
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
…t#5922)

Add dependencies in appropriate makefiles to ensure proper build/installation of SONiC platform daemons (ledd, psud, syseepromd, thermalctld, xcvrd).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants