[sonic-platform-common][sonic-platform-daemons] Update submodules #5917
Conversation
|
@mprabhu-nokia: The check builds are failing. It seems like you're referencing Can you please fix? Edit: After looking at this with fresh eyes, I believe this is not the root cause, but just something that should be improved. I believe we are also missing commits in sonic-platform-common. @vdahiya12: Can you please also update the sonic-platform-common submodule here and see if this passes the check builds? |
vdahiya12
force-pushed
the
update_sub_module
branch
from
4a1fd6c
to
0d59b91
Compare
d5c586e [xcvrd] Fix the console-script xcvrd startup (sonic-net#111) 8c2a5cc [Thermalctld] Update thermal info to CHASSIS_STATE_DB (sonic-net#101) 05c79de PSUd changes to compute power-budget for Modular chassis (sonic-net#104) a14c2bb Introduce chassisd to monitor status of cards on chassis (sonic-net#97) 850d0c6 [xcvrd] support for integrating Credo Y cable Ports initialization and status updates with xcvrd. (sonic-net#105) Signed-off-by: vaibhav-dahiya <[email protected]>
vdahiya12
force-pushed
the
update_sub_module
branch
from
124e5f4
to
c0300c6
Compare
Signed-off-by: vaibhav-dahiya <[email protected]>
Updated the PR with sonic-platform-common submodule update |
|
@vdahiya12: Thanks. Can you also update the title to |
vdahiya12
changed the title
|
@jleveque The psud tests still fail. The tests have a dependency on swsscommon.Table and swsscommon.FieldValuePairs and is failing there. I thought it picks up the mocked objects. Apparently, it does not. |
|
@mprabhu-nokia: It appears as though you are not importing mock_swsscommon in test_psud.py. Were these unit tests validated? We cannot disable or back out unit tests. You need to fix the tests, or we need to revert your changes, and you will need to add them back again with the proper fixes. |
Yes, it was unit-tested. Now, I see that existing unit-tests in thermalctld are also failing when manually run. The ordering of when swsscommon is built could be one of reasons. |
|
@mprabhu-nokia: You may be correct about the ordering of when swsscommon is built. The xcvrd and thermalctld makefiles should specify swsscommon as a dependency. I can open a PR to handle this. Edit: I have opened this PR to add the swsscommon dependencies. While I'm not sure this is the cause of the issue here, it is definitely something that was lacking. |
|
Superseded by #5924. Closing this PR. |
This PR updates the following commits in sonic-platform-daemons
d5c586e [xcvrd] Fix the console-script xcvrd startup (#111)
8c2a5cc [Thermalctld] Update thermal info to CHASSIS_STATE_DB (#101)
05c79de PSUd changes to compute power-budget for Modular chassis (#104)
a14c2bb Introduce chassisd to monitor status of cards on chassis (#97)
850d0c6 [xcvrd] support for integrating Credo Y cable Ports initialization and status updates with xcvrd. (#105)
This PR also updates the following commits in sonic-platform-common
0a13c7b Thermalctld APIs for recording min and max temp (#131)
8813b1d Common power consumption and supply APIs for modular chassis (#136)
b37f156 [sonic-platform-base] Introduce APIs for modular chassis support (#124)
9ba8189 Remove shebangs from non-executable Python files (#140)
fc3c1a0 [sonic_eeprom] Make compatible with Python 2 and 3 (#127)
012dc39 Add unit test infrastructure (#139)
Signed-off-by: vaibhav-dahiya [email protected]