Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[201911] Fix the error message for Tx Drop happening when netdev link is down #5550

Merged
merged 1 commit into from
Oct 6, 2020
Merged

[201911] Fix the error message for Tx Drop happening when netdev link is down #5550

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion platform/broadcom/saibcm-modules/systems/linux/kernel/modules/bcm-knet/bcm-knet.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5279,7 +5279,7 @@ bkn_tx(struct sk_buff *skb, struct net_device *dev)
}

if (!netif_carrier_ok(dev)) {
DBG_WARN(("Tx drop: Invalid RCPU encapsulation\n"));
DBG_WARN(("Tx drop: Netif link is down.\n"));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there way to get the device name in the log?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be print ifalias or name field?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev->name looks ok. But as a general comment, most of the debugs in this file don't have device name printed, may be to suggest brcm to improve debugs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prsunny and @judyjoseph Sure, will ask Broadcom to enhance debug messages. For now since this change same as what is in BRCM-SAI 4.2 will keep same so to avoid local changes.

priv->stats.tx_dropped++;
sinfo->tx.pkts_d_no_link++;
dev_kfree_skb_any(skb);
Expand Down