[201911] Fix the error message for Tx Drop happening when netdev link is down #5550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error message is updated to provide correct information of Netdevice link being down. Signed-off-by: Abhishek Dosi <[email protected]>
lguohan
reviewed
Oct 6, 2020
| @@ -5279,7 +5279,7 @@ bkn_tx(struct sk_buff *skb, struct net_device *dev) | |||
| } | |||
|
|
|||
| if (!netif_carrier_ok(dev)) { | |||
| DBG_WARN(("Tx drop: Invalid RCPU encapsulation\n")); | |||
| DBG_WARN(("Tx drop: Netif link is down.\n")); | |||
There was a problem hiding this comment.
is there way to get the device name in the log?
There was a problem hiding this comment.
May be print ifalias or name field?
There was a problem hiding this comment.
dev->name looks ok. But as a general comment, most of the debugs in this file don't have device name printed, may be to suggest brcm to improve debugs.
There was a problem hiding this comment.
@prsunny and @judyjoseph Sure, will ask Broadcom to enhance debug messages. For now since this change same as what is in BRCM-SAI 4.2 will keep same so to avoid local changes.
lguohan
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why/How I did:
The error message is updated to provide correct information
of Netdevice link being down for Tx Drop
Taken the change from BRCM SAI 4.2.1.3 (6.5.19 hsdk) (https://github.com/Azure/sonic-buildimage/pull/5532/files#diff-9787d8debde44bb0dd3ce502443bf25cR5362)