Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[snmp] Fix a bug in SNMP alias mapping #473

Merged
merged 3 commits into from
Apr 4, 2017
Merged

[snmp] Fix a bug in SNMP alias mapping #473

merged 3 commits into from
Apr 4, 2017

Conversation

taoyl-ms
Copy link
Contributor

@taoyl-ms taoyl-ms commented Apr 3, 2017

Which was introduced in #448.

@lguohan
Copy link
Collaborator

lguohan commented Apr 3, 2017

can you add a unit test for prevent such issue from happening?

@taoyl-ms taoyl-ms merged commit 8391d7f into master Apr 4, 2017
@taoyl-ms taoyl-ms deleted the taoyl/patch-1 branch April 20, 2017 22:10
@stcheng stcheng mentioned this pull request May 11, 2018
Merged
stcheng pushed a commit to stcheng/sonic-buildimage that referenced this pull request May 11, 2018
[swss]: Update sonic-swss submodule
85ce90d 
[lua]: use not to check whether the field exists (sonic-net#492)
[PFCWD]: Periodically poll WD counters (sonic-net#473)
[teamsyncd]: Add team_ifindex2ifname return value check (sonic-net#500)
[qos]: fix SAI_BUFFER_PROFILE_ATTR_SHARED_DYNAMIC_TH value mismatch bug (sonic-net#495)
[copporch]: Add SAI_HOSTIF_TRAP_TYPE_UDLD (sonic-net#480)

Signed-off-by: Shu0T1an ChenG <[email protected]>
lguohan pushed a commit that referenced this pull request May 11, 2018
@lguohan
[swss]: Update sonic-swss submodule (#1699)
d692905 
[lua]: use not to check whether the field exists (#492)
[PFCWD]: Periodically poll WD counters (#473)
[teamsyncd]: Add team_ifindex2ifname return value check (#500)
[qos]: fix SAI_BUFFER_PROFILE_ATTR_SHARED_DYNAMIC_TH value mismatch bug (#495)
[copporch]: Add SAI_HOSTIF_TRAP_TYPE_UDLD (#480)

Signed-off-by: Shu0T1an ChenG <[email protected]>
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Feb 28, 2019
@yxieca
[sub module] advance sonic-utilities sub module for 201811 branch
e159b89 
Submodule src/sonic-utilities ff1448c..f95da07:
  > [fast/warm reboot] set default reboot method to "kexec -e" (sonic-net#473)

Signed-off-by: Ying Xie <[email protected]>
@yxieca yxieca mentioned this pull request Feb 28, 2019
Merged
lguohan pushed a commit that referenced this pull request Feb 28, 2019
@yxieca @lguohan
[sub module] advance sonic-utilities sub module for 201811 branch (#2619
8617923 
)

Submodule src/sonic-utilities ff1448c..f95da07:
  > [fast/warm reboot] set default reboot method to "kexec -e" (#473)

Signed-off-by: Ying Xie <[email protected]>
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 10, 2019
@yxieca @tiantianlv
[sub module] advance sonic-utilities sub module for 201811 branch (so…
5957950 
…nic-net#2619)

Submodule src/sonic-utilities ff1448c..f95da07:
  > [fast/warm reboot] set default reboot method to "kexec -e" (sonic-net#473)

Signed-off-by: Ying Xie <[email protected]>
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 10, 2019
@yxieca @tiantianlv
[sub module] advance sonic-utilities sub module for 201811 branch (so…
a8cf325 
…nic-net#2619)

Submodule src/sonic-utilities ff1448c..f95da07:
  > [fast/warm reboot] set default reboot method to "kexec -e" (sonic-net#473)

Signed-off-by: Ying Xie <[email protected]>
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 10, 2019
@yxieca @tiantianlv
[sub module] advance sonic-utilities sub module for 201811 branch (so…
ca56c9f 
…nic-net#2619)

Submodule src/sonic-utilities ff1448c..f95da07:
  > [fast/warm reboot] set default reboot method to "kexec -e" (sonic-net#473)

Signed-off-by: Ying Xie <[email protected]>
stcheng pushed a commit to stcheng/sonic-buildimage that referenced this pull request Jul 19, 2019
[submodule]: Update swss related submodules
6b378b1 
swss:
[vxlanorch]: Allow ipv6 src ip for Vxlan tunnel creation (sonic-net#896)
[aclorch]: Allow DTEL drop actions in DTEL flow watchlist (sonic-net#915)
Fix typo in orchagent_restart_check from fasle to false. (sonic-net#923)
[sonic-swss]: Fix for FPM accept call failure in ARM arch (sonic-net#925)
Add retryCount option for orchagent_restart_check program. (sonic-net#833)
[vlan] Add pytest cases to validate nonexistent vlan behavior. (sonic-net#874)
[intfsorch] Wait for interface prior to prefix (sonic-net#796)
Set timer only when interval changes. Not in each firing of the timer. (sonic-net#945)
[test]: Fix set interface in configuration database (sonic-net#956)
[copporch]: Fix polymorphic type error (sonic-net#946)
[AclOrch]: Fix the acl mirror counter doubled by inactive mirror and active again (sonic-net#952)
[MirrorOrch]: Init the next hop ip with 0 instead of default constructor (sonic-net#953)
[portsorch]: Add reference count of port (sonic-net#962)
[mock_test]: Move mock tests into a separate folder to separate them from vs tests (sonic-net#950)
remove crm acl_counters when acl_table removed (sonic-net#918)
[aclorch]: Fix matching MIRROR_DSCP throws unnecessary errors (sonic-net#966)
[policerorch]: Fix return code comparison error (sonic-net#968)
[gitignore]: Add swss-dbg related files (sonic-net#967)
[vxlanmgrd]: Fix for vxlanmgrd cannot correctly work after config reload (sonic-net#934)
[vxlanorch]: Add extra info into NOTICE logs (sonic-net#891)
[test]: Add a neighbor entry with BCAST MAC and verify its ignored (sonic-net#955)
[copporch]: Fix copporch in DEL command (sonic-net#972)
[orchagent]: Fix crash during orchagent process exit (sonic-net#974)
[vnetorch]: Fix VNET orchagents order for warm-reboot flow (sonic-net#958)
[test]: Skip unstable test test_vnet_orch_1 (sonic-net#976)
[intfsorch]: Fix rif flex counter removal error (sonic-net#975)
Update tests README.md file
[aclorch]: Change CFG_ACL_TABLE_NAME to CFG_ACL_TABLE_TABLE_NAME (sonic-net#978)
[test]: Skip test_watermark.py::TestWatermark::test_lua_plugins (sonic-net#981)
[teamsyncd]: Add information for LAG membership changes (sonic-net#982)

common:
Add an assert to logger, which will log a message and abort. (sonic-net#286)
[test]: Add IpAddress::isZero() unit test (sonic-net#289)
do not abort when read timerfd return 0 and errno = 0 (sonic-net#291)
Add BGP_STATE_TABLE in stateDB (sonic-net#273)
[IpAddress]: add mcast scope on address and isFullMask method on prefix (sonic-net#285)
Add ignore Wshadow pragma to json.hpp (sonic-net#292)
[executor]: Fix Executor does not get correct priority saved in m_selectable (sonic-net#290)
[schema]: Remove duplicate STATE_MIRROR_SESSION_TABLE_NAME (sonic-net#294)
timerfd:read failure - Record in logs as error. (sonic-net#295)
[schema]: Change CFG_ACL_TABLE_NAME to CFG_ACL_TABLE_TABLE_NAME (sonic-net#296)
[schema]: Add PASS_THROUGH_ROUTE_TABLE to config and application db (sonic-net#297)

sairedis:
ARM32 bit fixes, for 64bit printf format specifier (sonic-net#468)
Reduce the timeout (GET_RESPONSE_TIMEOUT) from 6 minutes to 1 minute. (sonic-net#472)
Fixed config_syncd_barefoot function (sonic-net#474)
[syncd_init_common.sh] fix fast reboot backwards compatibility (sonic-net#480)
Add default bridge id for bridge port id of type PORT in virtual switch (sonic-net#473)
Fix a bug in parsing kernel argument of fast-reboot (sonic-net#482)
Add TimerWatchdog for monitoring long execution apis (sonic-net#469)
Add specific comparison logic for tunnel map (sonic-net#475)
[vslib] add ACL action capabilities support (sonic-net#481)
Per buffer pool watermark polling mode (sonic-net#485)
Add specific comparison logic for ACL counter (sonic-net#484)
Process flex counters requests in separate thread (sonic-net#483)
Make sairedis/syncd synchronous (sonic-net#476)
Fixed conditional operator. (sonic-net#487)

Signed-off-by: Shu0T1an ChenG <[email protected]>
@stcheng stcheng mentioned this pull request Jul 19, 2019
Merged
lguohan pushed a commit that referenced this pull request Jul 20, 2019
@stcheng @lguohan
[submodule]: Update swss related submodules (#3190)
01a5bea 
swss:
[vxlanorch]: Allow ipv6 src ip for Vxlan tunnel creation (#896)
[aclorch]: Allow DTEL drop actions in DTEL flow watchlist (#915)
Fix typo in orchagent_restart_check from fasle to false. (#923)
[sonic-swss]: Fix for FPM accept call failure in ARM arch (#925)
Add retryCount option for orchagent_restart_check program. (#833)
[vlan] Add pytest cases to validate nonexistent vlan behavior. (#874)
[intfsorch] Wait for interface prior to prefix (#796)
Set timer only when interval changes. Not in each firing of the timer. (#945)
[test]: Fix set interface in configuration database (#956)
[copporch]: Fix polymorphic type error (#946)
[AclOrch]: Fix the acl mirror counter doubled by inactive mirror and active again (#952)
[MirrorOrch]: Init the next hop ip with 0 instead of default constructor (#953)
[portsorch]: Add reference count of port (#962)
[mock_test]: Move mock tests into a separate folder to separate them from vs tests (#950)
remove crm acl_counters when acl_table removed (#918)
[aclorch]: Fix matching MIRROR_DSCP throws unnecessary errors (#966)
[policerorch]: Fix return code comparison error (#968)
[gitignore]: Add swss-dbg related files (#967)
[vxlanmgrd]: Fix for vxlanmgrd cannot correctly work after config reload (#934)
[vxlanorch]: Add extra info into NOTICE logs (#891)
[test]: Add a neighbor entry with BCAST MAC and verify its ignored (#955)
[copporch]: Fix copporch in DEL command (#972)
[orchagent]: Fix crash during orchagent process exit (#974)
[vnetorch]: Fix VNET orchagents order for warm-reboot flow (#958)
[test]: Skip unstable test test_vnet_orch_1 (#976)
[intfsorch]: Fix rif flex counter removal error (#975)
Update tests README.md file
[aclorch]: Change CFG_ACL_TABLE_NAME to CFG_ACL_TABLE_TABLE_NAME (#978)
[test]: Skip test_watermark.py::TestWatermark::test_lua_plugins (#981)
[teamsyncd]: Add information for LAG membership changes (#982)

common:
Add an assert to logger, which will log a message and abort. (#286)
[test]: Add IpAddress::isZero() unit test (#289)
do not abort when read timerfd return 0 and errno = 0 (#291)
Add BGP_STATE_TABLE in stateDB (#273)
[IpAddress]: add mcast scope on address and isFullMask method on prefix (#285)
Add ignore Wshadow pragma to json.hpp (#292)
[executor]: Fix Executor does not get correct priority saved in m_selectable (#290)
[schema]: Remove duplicate STATE_MIRROR_SESSION_TABLE_NAME (#294)
timerfd:read failure - Record in logs as error. (#295)
[schema]: Change CFG_ACL_TABLE_NAME to CFG_ACL_TABLE_TABLE_NAME (#296)
[schema]: Add PASS_THROUGH_ROUTE_TABLE to config and application db (#297)

sairedis:
ARM32 bit fixes, for 64bit printf format specifier (#468)
Reduce the timeout (GET_RESPONSE_TIMEOUT) from 6 minutes to 1 minute. (#472)
Fixed config_syncd_barefoot function (#474)
[syncd_init_common.sh] fix fast reboot backwards compatibility (#480)
Add default bridge id for bridge port id of type PORT in virtual switch (#473)
Fix a bug in parsing kernel argument of fast-reboot (#482)
Add TimerWatchdog for monitoring long execution apis (#469)
Add specific comparison logic for tunnel map (#475)
[vslib] add ACL action capabilities support (#481)
Per buffer pool watermark polling mode (#485)
Add specific comparison logic for ACL counter (#484)
Process flex counters requests in separate thread (#483)
Make sairedis/syncd synchronous (#476)
Fixed conditional operator. (#487)

Signed-off-by: Shu0T1an ChenG <[email protected]>
Kalimuthu-Velappan pushed a commit to Kalimuthu-Velappan/sonic-buildimage that referenced this pull request Sep 12, 2019
@yxieca
[fast/warm reboot] set default reboot method to "kexec -e" (sonic-net…
1f7f44f 
…#473)

'/sbin/reboot' randomly trigger a delay in shutdown path on some
platforms, this delay caused the lags to timeout.

Tested 'kexec -e' 1500+ times and never triggered the shutdown delay.

Signed-off-by: Ying Xie <[email protected]>
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020
@marian-pritsak @sihuihan88
[PFCWD]: Periodically poll WD counters (sonic-net#473)
477d124 
* [PFCWD]: Periodically poll WD counters

For every action handler call commitCounters on a periodic basis

Signed-off-by: marian-pritsak <[email protected]>

* Set polling interval to 1s
dmytroxshevchuk pushed a commit to dmytroxshevchuk/sonic-buildimage that referenced this pull request Aug 31, 2020
@kcudnik
Add default bridge id for bridge port id of type PORT in virtual swit…
6dc0a85 
…ch (sonic-net#473)

* Add default bridge id for bridge port id of type PORT in virtual switch

* Update recording

Virtual switch now supports Queue TYPE, so tests must be updated

* Address comments
qiluo-msft added a commit that referenced this pull request Jul 28, 2021
@qiluo-msft
[sonic-swss-common] Update submodule (#8272)
9642ea0 
Includes below commits
```
bf8c832 2021-07-22 | Fix DBInterface blocking operations (#505) (HEAD -> 202012, origin/202012) [Qi Luo]
0e9385f 2021-04-21 | [swig] Implement SonicV2Connector.hmset() (#480) [Qi Luo]
76be49f 2021-07-25 | Modify the hardcode separator ":" to variable. (#473) [PJHsieh]
142ae3c 2021-06-23 | Fix config prompt question issue (#500) [xumia]
e7bebe1 2021-06-14 | Fix repo reference issue (#487) [xumia]
```
qiluo-msft added a commit that referenced this pull request Aug 5, 2021
@qiluo-msft
[sonic-swss-common] Update submodule (#8344)
1270da8 
Includes below commits
```
e95a466 2021-08-04 | Fix: DBInterface::get() return nullable strings (#516) [Qi Luo]
f89b2ac 2021-07-29 | [netlink]refill netlink cache when failing to get the link object by name. (#506) [wangshengjun]
22b8715 2021-07-26 | Fix test_ConfigDBSubscribe timing risk (#512) [Qi Luo]
27dbcea 2021-07-26 | added missing headers for building with gcc-10.3 (#494) [Denis Pronin]
7f6ab6d 2021-07-25 | Modify the hardcode separator ":" to variable. (#473) [PJHsieh]
```
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
@qiluo-msft
[sonic-swss-common] Update submodule (sonic-net#8344)
434b1e0 
Includes below commits
```
e95a466 2021-08-04 | Fix: DBInterface::get() return nullable strings (sonic-net#516) [Qi Luo]
f89b2ac 2021-07-29 | [netlink]refill netlink cache when failing to get the link object by name. (sonic-net#506) [wangshengjun]
22b8715 2021-07-26 | Fix test_ConfigDBSubscribe timing risk (sonic-net#512) [Qi Luo]
27dbcea 2021-07-26 | added missing headers for building with gcc-10.3 (sonic-net#494) [Denis Pronin]
7f6ab6d 2021-07-25 | Modify the hardcode separator ":" to variable. (sonic-net#473) [PJHsieh]
```
TACappleman added a commit to Metaswitch/sonic-buildimage that referenced this pull request Aug 24, 2021
@TACappleman
Updating sonic-swss-common submodule
6b60192 
> Add a new field for FLEX_COUNTER_TABLE to indicate delay for flex counters (sonic-net#523)
> [logger] Make map access thread safe and proper terminate thread (sonic-net#510)
> Test with coverage output, publish gcov on Azure pipelines (sonic-net#517)
> Update schema.h to include config_db DHCP and state_db counter table (sonic-net#521)
> [schema] Add next hop group table to schema (sonic-net#475)
> Fix: DBInterface::get() return nullable strings (sonic-net#516)
> [netlink]refill netlink cache when failing to get the link object by name. (sonic-net#506)
> Fix test_ConfigDBSubscribe timing risk (sonic-net#512)
> added missing headers for building with gcc-10.3 (sonic-net#494)
> Modify the hardcode separator ":" to variable. (sonic-net#473)
@TACappleman TACappleman mentioned this pull request Aug 24, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

Assignees
No one assigned
Labels
Bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taoyl-ms @lguohan @jleveque