[minigraph.py] Enable telemetry service by default #3611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
changed the title
jleveque
suggested changes
Oct 15, 2019
jleveque
suggested changes
Oct 16, 2019
pra-moh
force-pushed
the
pramoh/enabletelemetry
branch
from
ece1b91
to
949baeb
Compare
jleveque
suggested changes
Oct 16, 2019
|
Retest vs please |
nikos-github
suggested changes
Oct 17, 2019
|
@nikos-github: Even when loading from minigraph? This section of code will only write this section to the config_db.json when loading from minigraph. Otherwise, if there are no "on"/"enabled" entries in config_db.json, the default behavior will be "disabled". Is this still an issue for you? |
|
@jleveque Ok if this default enabling doesn't propagate to config_db.json, I have no issues. |
|
@nikos-github: It will only propagate to config_db.json if you are loading your config from a minigraph file. |
|
@jleveque Does the first install config of config_db.json load from minigraph? |
|
@nikos-github: No. Initial config is in JSON format. |
jleveque
approved these changes
Oct 22, 2019
|
@pra-moh: Please resolve new conflicts. |
jleveque
suggested changes
Oct 23, 2019
…to pramoh/enabletelemetry
jleveque
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Enabling telemetry feature by default
- How I did it
on minigraph load adding new table in config db as 'features|telemetry' {'status':'on'}
- How to verify it
config load_minigraph
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)