Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit for SONiC PDE (platform development environment) for s… #3408

Closed
wants to merge 80 commits into from
Closed

Conversation

wbschwar
Copy link

@wbschwar wbschwar commented Sep 5, 2019

  • What I did

This PR is for the build infrastructure changes to support the PDE (platform development environment). For additional detail see:
sonic-net/SONiC#407

Enable PDE by un-commenting line in rules/config
ENABLE_PDE=y

build PDE enabled SONiC install image
make target/sonic-$MACHINE-pde.bin

Currently only Broadcom support has been added.

  • Description for the changelog
    Adding support for Platform Development Environment (PDE)

  • A picture of a cute animal (not mandatory but encouraged)

wbschwar and others added 18 commits October 22, 2019 13:41
Somehow this was missed in april, I added the icons for 201904 so that
the branch is not forgotten

Signed-off-by: Michel Moriniaux <[email protected]>
c12c443 - 2019-10-22 : [command reference] add warm reboot command document (#704) [Ying Xie]
e25cf29 - 2019-10-22 : [PR template] Add reminder to add/modify/remove unit tests as appropriate (#708) [Joe LeVeque]
66eafce - 2019-10-19 : [Command Reference] Unify style and formatting; Fix organization; Other fixes (#707) [Joe LeVeque]
f32a450 - 2019-10-19 : [generate_dump] Make regex more specific for disabling/enabling logrotate (#701) [Kalimuthu-Velappan]
d77c411 - 2019-10-18 : [netstat]: Fix for negative output values of counters after clear counters operation (#697) [lyndonsiao]
fc324f2 - 2019-10-18 : [neighbor_advertiser]: Adapt to different mirror ACL table names (#703) [Shuotian Cheng]
342f3a1 - 2019-10-08 : [intfstat,portstat] fix table_as_json (#691) [Mykola F]
5564d87 - 2019-10-07 : [acl-loader] egress mirror action support and action ASIC support check (#575) [Stepan Blyshchak]
Added pre-emphasis values for the Inventec d6356 platform using media_settings.json.
#3627)

Now it's possible to add and remove peers based on ConfigDB

- What I did
Fixed functionality for dynamically adding/removing static bgp peers.

- How I did it

Split the bgp default template on bgp part and bgp peer part
Changed bgpcfgd to use 1.

- How to verify it

Build an image and run on your DUT
…e entries (#3644)

[Makefile] Kill arm march docker service before every run to avoid stale entries
[Platform] Marvell - add dtb deb pkg

Signed-off-by: Antony Rheneus <[email protected]>
* [portsyncd] Remove "-p port_config.ini" option from the portsyncd

Signed-off-by: Zhenggen Xu <[email protected]>
We noticed in tests/production that there is a low probability failure
where /etc/hosts could have some garbage characters before the entry for
local host name. The consequence is that all sudo command would be very
slow. In extreme cases it would prevent some services from starting
properly.

I suspect that the /etc/hosts file might be opened by some process causing
the issue. Editing contents with new file level and replace the whole file
should be safer.

Signed-off-by: Ying Xie <[email protected]>
@lguohan
Copy link
Collaborator

lguohan commented Oct 30, 2019

retest this please

yozhao101 and others added 7 commits October 30, 2019 16:41
#3684)

- support SAI 1.5.0
- fix docker syncd related makefile error
* [sonic-cfggen] optimize execution time

a lot of template rendering causes switch to start longer because jinja2
needs to parse them. Introducing RedisBytecodeCache to store parsed buckets of
internal template bytecode to speedup same template rendering during start

* [sonic-cfggen] do lazy regexp compilation to speedup sonic-cfggen

* [sonic-cfggen] address pep8 related comments

Signed-off-by: Stepan Blyschak <[email protected]>
* [services] improve startup time by given precedence to critical services (syncd.service)

Signed-off-by: Stepan Blyschak <[email protected]>
* [minigraph.py]: Use default namespace for <Address>
@wbschwar
Copy link
Author

wbschwar commented Nov 4, 2019

retest this please

akokhan and others added 11 commits November 8, 2019 21:43
…3622)

Implement Component platform2.0 API for accton as7116-54x platform
Added python-libpcap to be used by arp_responder.py utility. This is needed to set conf.use_pcap which will make sure that L2pcapListenSocket uses libpcap instead of Linux PF_PACKET sockets. By using libpcap the vlan field will not be removed when the application receives the packet.
* In the event of a kernel crash, we need to gather as much information
as possible to understand and identify the root cause of the crash.
Currently, the kernel does not provide much information, which make
kernel crash investigation difficult and time consuming.

Fortunately, there is a way in the kernel to provide more information
in the case of a kernel crash. kdump is a feature of the Linux kernel
that creates crash dumps in the event of a kernel crash. This PR
will add kermel kdump support.

An extension to the CLI utilities config and show is provided to
configure and manage kdump:
 - enable / disable kdump functionality
 - configure kdump (how many kernel crash logs can be saved, memory
   allocated for capture kernel)
 - view kernel crash logs
…is modified. (#3705)

When LLDP parameter tx-interval value is modified, there was no immediate PDU sent to peer to update the peer with the latest values. Due to this the update on peer happened only after the next PDU is sent which can cause a delay of upto 30 secs (default value).
…AS7326-56X/AS7726-56X (#3726)

AS7326-56X and AS7726-56X use the same design so both devices have the same problem.
The detailed description below takes AS7326-56X as the example to explain.

Original implementation:
- In platform/broadcom/sonic-platform-modules-accton/as7326-56x/service/as7326-platform-handle_mac.service,
  it executes the script file "accton_handle_idt.sh".
- In "accton_handle_idt.sh", it modifies the content of the script file "/etc/init.d/opennsl-modules"
  to insert the lines to execute "idt_init.sh" before the command to load broadcom linux kernel module "linux-kernel-bde.ko".
- The script "idt_init.sh" cannot be executed at the first boot of SONiC after installing SONiC under ONIE. This is the reason why all of the ports does not work.

New implementation:
- Let "as7326-platform-handle_mac.service" execute "idt_init.sh".
- Change the content of "as7326-platform-handle_mac.service" to define the service type as "oneshot". Add the settings to ensure "as7326-platform-handle_mac.service" is executed before "opennsl-modules.service".
  By setting the service type as "oneshot", it is guaranteed that "opennsl-modules.services" is started only when the forked process to execute the script file "idt_init.sh" is terminated

Signed-off-by: charlie_chen <[email protected]>
…cal process in syncd container exits unexpectedly (#3534)

Add the same mechanism I developed for the SwSS service in #2845 to the syncd service. However, in order to cause the SwSS service to also exit and restart in this situation, I developed a docker-wait-any program which the SwSS service uses to wait for either the swss or syncd containers to exit.
swss:
* f354798 2019-11-09 | [tests] fix build agains real SAI (#1123) (HEAD, origin/master, origin/HEAD) [Stepan Blyshchak]
* 56d66a1 2019-11-07 | Sub port interface implementation (#969) [Wenda Ni]
* c57fc34 2019-11-07 | [bufferorch] Fixed buffer and buffer profile attributes types accoring to changes in SAI 1.5 (#1120) [Vitaliy Senchyshyn]
* 85ff17d 2019-11-07 | [VRF]: submit vrf feature  (#943) [Tyler Li]
* 5604566 2019-11-06 | [vs_test] fix fdb test failed randomly (#1118) [Tyler Li]
* 038d994 2019-11-05 | [vnet]: Correct VNET route table size for BITMAP implementation (#1115) [Volodymyr Samotiy]
* bb4e19c 2019-11-04 | Not wait till kernel net_devices are created for all physical ports to (#1109) [Wenda Ni]
* bab7b93 2019-11-02 | [portsorch] fix PortsOrch::allPortsReady() returns true when it should not (#1103) [Stepan Blyshchak]
* 5ab3f6b 2019-10-31 | Updating pytest for sflow (#1095) [Sudharsan D.G]
* d4ccdc3 2019-10-29 | Quote input strings before constructing a command line (#1098) [Qi Luo]
* 5516ec4 2019-10-29 | Check RIF/Port exists only for add entries (#1110) [Prince Sunny]
* 59440f2 2019-10-29 | Allow buffer profile apply after init (#1099) [Wenda Ni]

sairedis:
* d9faa58 2019-10-24 | Copp changes for supporting genetlink in vs (#522) [Sudharsan D.G]

utiltiies:
* e4a5e4c 2019-11-07 | Do not start pfcwd for M0 devices (#726) (HEAD, origin/master, origin/HEAD) [Neetha John]
* 2c0af8a 2019-11-07 | Add an on/off knob for BGP EOIU pulling on warm restart (#655) [heidinet2007]
* 2bce9ce 2019-11-07 | Make configlet application script idempotent for updates. (#728) [Renuka Manavalan]
* 4740617 2019-11-06 | Revert "show BPS, PPS, UTIL rates w/o previous clear (#508)" (#718) [Mykola F]
@wbschwar
Copy link
Author

retest this please

ds952811 and others added 14 commits November 12, 2019 15:26
* afe2a0d 2019-10-30 | [vs]: Fix learn fdb events after fdb flush event (#524) (HEAD, origin/master, origin/HEAD) [Kamil Cudnik]
* d29760f 2019-10-28 | [sai_redis_interface_query] Add sairedis support for sai_object_type_get_availability (#528) [Danny Allen]
* ff5306e 2019-10-28 | [sai_redis_interface_query] Add sairedis support for sai_query_attribute_enum_values_capability (#525) [Danny Allen]

Signed-off-by: Guohan Lu <[email protected]>
* Updating the platform README

Added the steps for configuring FEC mode

Signed-off-by: Ciju Rajan K <[email protected]>
…m start, if configured so (#3489)

* start bgp_eoiu_mark service to populate bgp eoiu marker if configured so

* Address code review comments: check db value via "-v" option in sonic-cfggen

* Address code review comment 2: check string against 'true' directly, instead of couting

* Update start.sh
- optoe driver truncates invalid pages(ff) but sff driver doesn't truncate.so,the DOM related calculation made by sff8436 driver will show incorrect data.
- Few optics doesn't support DOM.
- SFP plugins currently returns None for unreadable pages and this'd throw the below mentioned error in sfpshow eeprom --dom.
This PR is to handle the issue 3527.
When device boots up, NTP throws a traceback as explained in the issue 3527.

- Traceback will be seen when MGMT_VRF_CONFIG does not exist in the database. Traceback is coming from the script “/etc/init.d/ntp”.

- Traceback does not affect the NTP functionality with/without management VRF. When MGMT_VRF_CONFIG does not exist or when MGMT_VRF_CONFIG’s mgmtVrfEnabled is configured to “false”, “NTP” will be started in the “default VRF” context, which is working fine even with this traceback.

- This traceback error will be hidden by redirecting the error to /dev/null without affecting functionality.
…,z9100,s6100,z9264f) (#3743)

* This method is used to update firmware components such as CPLD,FPGA,BIOS,SMF
           * This uses ONIE firmware upgrade design to stage firmware update from NOS.

a) Copy latest firmware updater image to target running sonic.
b) Run “./fw-updater -u onie-firmware-x86_64-dellemc_s5200_c3538-r0.3.40.5.1-9.bin”.
c) This would automatically reboot ONIE into update mode and update firmware components to latest and reboot back to sonic without any user intervention.

Signed-off-by: Srideep Devireddy <[email protected]>
@wbschwar wbschwar closed this Nov 15, 2019
mssonicbld added a commit that referenced this pull request Jul 24, 2024
…atically (#19669)

#### Why I did it
src/sonic-utilities
```
* 772ee793 - (HEAD -> master, origin/master, origin/HEAD) IP Assignment Issue (#3408) (5 hours ago) [Rida Hanif]
* f1966227 - fix show techsupport date issue (#3437) (19 hours ago) [ganglv]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mssonicbld added a commit that referenced this pull request Jul 25, 2024
…atically (#19680)

#### Why I did it
src/sonic-utilities
```
* 226fd22c - (HEAD -> 202405, origin/202405) IP Assignment Issue (#3408) (7 hours ago) [Rida Hanif]
```
#### How I did it
#### How to verify it
#### Description for the changelog
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Aug 1, 2024
…atically (sonic-net#19669)

#### Why I did it
src/sonic-utilities
```
* 772ee793 - (HEAD -> master, origin/master, origin/HEAD) IP Assignment Issue (sonic-net#3408) (5 hours ago) [Rida Hanif]
* f1966227 - fix show techsupport date issue (sonic-net#3437) (19 hours ago) [ganglv]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.