Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix teamd patch issues, which prevented system WR #2321

Merged
merged 1 commit into from
Nov 30, 2018
Merged

Fix teamd patch issues, which prevented system WR #2321

merged 1 commit into from
Nov 30, 2018

Conversation

pavel-shirshov
Copy link
Contributor

- What I did

  1. Fixed vanilla teamd bug, which prevented teamd to have a correct view of kernel state. Check bug #2 from the message
  2. Changed schema for LACP port id.
  3. Changed severity of an error message.
  4. Removed logic to disable warm_start_read mode, when teamd started. It didn't work in system restart mode, because interfaces were added one by one, and it's impossible to say when everything is added.

- How I did it

  1. I've added team_refresh() on every port addition
  2. I extract port id from the port name. Currently I support only "EthernetX" scheme. We need to add more schemes if we change port scheme.
  3. _err -> _info
  4. ...

- How to verify it
Build the image, install on your DUT, reboot it once, then reboot it on WR mode checking LACP state on remote side. The state shouldn't flip.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@pavel-shirshov pavel-shirshov self-assigned this Nov 30, 2018
@lguohan lguohan merged commit c7d18f1 into master Nov 30, 2018
@lguohan lguohan deleted the pavelsh/teamd_restart branch December 5, 2018 08:27
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Jun 9, 2022
@yxieca
[202205][linkmgrd][sairedis] advance submodule head
848a45c 
linkmgrd:
* 2da783b 2022-06-07 | Check self's mux mode before switching peer to standby & add support for `detach` mode (sonic-net#79) (HEAD -> 202205, github/202205) [Jing Zhang]

sairedis:
* 54642c7 2022-06-09 | [counter] Fix port flex counter  (sonic-net#1052) (HEAD -> 202205, github/202205) [Junhua Zhai]
* b7f5f92 2022-06-06 | [ci] Paralize azure pipeline  (sonic-net#1054) [Shilong Liu]

swss:
* 77043fb 2022-06-09 | [fpmsyncd] don't manipulate route weight (sonic-net#2321) (HEAD -> 202205, github/202205) [Ying Xie]
* ae157f1 2022-06-10 | Fix test_warm_reboot issues blocking PR merge (sonic-net#2309) (sonic-net#2318) [Shilong Liu]

Signed-off-by: Ying Xie <[email protected]>
@yxieca yxieca mentioned this pull request Jun 9, 2022
Merged
yxieca added a commit that referenced this pull request Jun 10, 2022
@yxieca
[202205][linkmgrd][sairedis] advance submodule head (#11091)
c7d8f51 
linkmgrd:
* 2da783b 2022-06-07 | Check self's mux mode before switching peer to standby & add support for `detach` mode (#79) (HEAD -> 202205, github/202205) [Jing Zhang]

sairedis:
* 54642c7 2022-06-09 | [counter] Fix port flex counter  (#1052) (HEAD -> 202205, github/202205) [Junhua Zhai]
* b7f5f92 2022-06-06 | [ci] Paralize azure pipeline  (#1054) [Shilong Liu]

swss:
* 77043fb 2022-06-09 | [fpmsyncd] don't manipulate route weight (#2321) (HEAD -> 202205, github/202205) [Ying Xie]
* ae157f1 2022-06-10 | Fix test_warm_reboot issues blocking PR merge (#2309) (#2318) [Shilong Liu]

Signed-off-by: Ying Xie <[email protected]>
robertvolkmann pushed a commit to robertvolkmann/sonic-buildimage that referenced this pull request Jul 26, 2022
@yxieca @robertvolkmann
[202205][linkmgrd][sairedis] advance submodule head (sonic-net#11091)
ea34d59 
linkmgrd:
* 2da783b 2022-06-07 | Check self's mux mode before switching peer to standby & add support for `detach` mode (sonic-net#79) (HEAD -> 202205, github/202205) [Jing Zhang]

sairedis:
* 54642c7 2022-06-09 | [counter] Fix port flex counter  (sonic-net#1052) (HEAD -> 202205, github/202205) [Junhua Zhai]
* b7f5f92 2022-06-06 | [ci] Paralize azure pipeline  (sonic-net#1054) [Shilong Liu]

swss:
* 77043fb 2022-06-09 | [fpmsyncd] don't manipulate route weight (sonic-net#2321) (HEAD -> 202205, github/202205) [Ying Xie]
* ae157f1 2022-06-10 | Fix test_warm_reboot issues blocking PR merge (sonic-net#2309) (sonic-net#2318) [Shilong Liu]

Signed-off-by: Ying Xie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

@yxieca yxieca Awaiting requested review from yxieca

Assignees

@pavel-shirshov pavel-shirshov

Labels
Bug 🐛 Enhancement ➕
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavel-shirshov @lguohan