[Platform] [Accton] Validate mii-tool access on management port. #2318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idate mdio to external PHY. Signed-off-by: roy_lee <[email protected]>
lguohan
approved these changes
Nov 29, 2018
|
I have comments on the other PR. |
|
@roylee123 , can you update the kernel submodule in this PR? |
Signed-off-by: roy_lee <[email protected]>
|
Hi, I've updated the kernel submodule. |
lguohan
reviewed
Dec 3, 2018
| ONIE_PLATFORM_EXTRA_CMDLINE_LINUX="pci=noaer" | ||
| ONIE_PLATFORM_EXTRA_CMDLINE_LINUX="tg3.short_preamble=1 tg3.bcm5718s_reset=1" |
There was a problem hiding this comment.
should you just have one ONIE_PLATFORM_EXTRA_CMDLINE_LINUX? Are they conflicting to each other?
There was a problem hiding this comment.
@lguohan, you are right. This platform is not even maintained by Accton.
I should restore it back.
…ton. Signed-off-by: roy_lee <[email protected]>
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Jun 9, 2022
linkmgrd: * 2da783b 2022-06-07 | Check self's mux mode before switching peer to standby & add support for `detach` mode (sonic-net#79) (HEAD -> 202205, github/202205) [Jing Zhang] sairedis: * 54642c7 2022-06-09 | [counter] Fix port flex counter (sonic-net#1052) (HEAD -> 202205, github/202205) [Junhua Zhai] * b7f5f92 2022-06-06 | [ci] Paralize azure pipeline (sonic-net#1054) [Shilong Liu] swss: * 77043fb 2022-06-09 | [fpmsyncd] don't manipulate route weight (sonic-net#2321) (HEAD -> 202205, github/202205) [Ying Xie] * ae157f1 2022-06-10 | Fix test_warm_reboot issues blocking PR merge (sonic-net#2309) (sonic-net#2318) [Shilong Liu] Signed-off-by: Ying Xie <[email protected]>
yxieca
added a commit
that referenced
this pull request
Jun 10, 2022
linkmgrd: * 2da783b 2022-06-07 | Check self's mux mode before switching peer to standby & add support for `detach` mode (#79) (HEAD -> 202205, github/202205) [Jing Zhang] sairedis: * 54642c7 2022-06-09 | [counter] Fix port flex counter (#1052) (HEAD -> 202205, github/202205) [Junhua Zhai] * b7f5f92 2022-06-06 | [ci] Paralize azure pipeline (#1054) [Shilong Liu] swss: * 77043fb 2022-06-09 | [fpmsyncd] don't manipulate route weight (#2321) (HEAD -> 202205, github/202205) [Ying Xie] * ae157f1 2022-06-10 | Fix test_warm_reboot issues blocking PR merge (#2309) (#2318) [Shilong Liu] Signed-off-by: Ying Xie <[email protected]>
robertvolkmann
pushed a commit
to robertvolkmann/sonic-buildimage
that referenced
this pull request
Jul 26, 2022
linkmgrd: * 2da783b 2022-06-07 | Check self's mux mode before switching peer to standby & add support for `detach` mode (sonic-net#79) (HEAD -> 202205, github/202205) [Jing Zhang] sairedis: * 54642c7 2022-06-09 | [counter] Fix port flex counter (sonic-net#1052) (HEAD -> 202205, github/202205) [Junhua Zhai] * b7f5f92 2022-06-06 | [ci] Paralize azure pipeline (sonic-net#1054) [Shilong Liu] swss: * 77043fb 2022-06-09 | [fpmsyncd] don't manipulate route weight (sonic-net#2321) (HEAD -> 202205, github/202205) [Ying Xie] * ae157f1 2022-06-10 | Fix test_warm_reboot issues blocking PR merge (sonic-net#2309) (sonic-net#2318) [Shilong Liu] Signed-off-by: Ying Xie <[email protected]>
kuba-moo
pushed a commit
to linux-netdev/testing
that referenced
this pull request
Aug 2, 2024
Add parameter to enable *short preamble* for MAC, so MDIO access to some
external PHY, like BCM54616, can be validated.
Applies to the five platforms below, that have the ethernet controller
BCM5720:
as7116_54x, as7326_56x, as7716_32x-r0, as7716_32xb, and as7816_64x
Verified by mii-tool. (31 is the address of external phy).
root@sonic:/home/admin# mii-tool -v eth0 -p 31
using the specified MII index 31.
eth0: negotiated, link ok
product info: vendor 00:d8:97, model 17 rev 2
basic mode: autonegotiation enabled
basic status: autonegotiation complete, link ok
capabilities: 1000baseT-HD 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD
advertising: flow-control
link partner: 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD
Note, this upstreams a patch to the SONiC Linux kernel added in 2018
[1][2][3].
[1]: sonic-net/sonic-linux-kernel#71
[2]: sonic-net/sonic-linux-kernel@ad754bd
[3]: sonic-net/sonic-buildimage#2318
Signed-off-by: Roy Lee <[email protected]>
Signed-off-by: Paul Menzel <[email protected]>
Signed-off-by: NipaLocal <nipa@local>
kuba-moo
pushed a commit
to linux-netdev/testing
that referenced
this pull request
Aug 2, 2024
Add parameter to enable *short preamble* for MAC, so MDIO access to some
external PHY, like BCM54616, can be validated.
Applies to the five platforms below, that have the ethernet controller
BCM5720:
as7116_54x, as7326_56x, as7716_32x-r0, as7716_32xb, and as7816_64x
Verified by mii-tool. (31 is the address of external phy).
root@sonic:/home/admin# mii-tool -v eth0 -p 31
using the specified MII index 31.
eth0: negotiated, link ok
product info: vendor 00:d8:97, model 17 rev 2
basic mode: autonegotiation enabled
basic status: autonegotiation complete, link ok
capabilities: 1000baseT-HD 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD
advertising: flow-control
link partner: 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD
Note, this upstreams a patch to the SONiC Linux kernel added in 2018
[1][2][3].
[1]: sonic-net/sonic-linux-kernel#71
[2]: sonic-net/sonic-linux-kernel@ad754bd
[3]: sonic-net/sonic-buildimage#2318
Signed-off-by: Roy Lee <[email protected]>
Signed-off-by: Paul Menzel <[email protected]>
Signed-off-by: NipaLocal <nipa@local>
kuba-moo
pushed a commit
to linux-netdev/testing
that referenced
this pull request
Aug 2, 2024
Add parameter to enable *short preamble* for MAC, so MDIO access to some
external PHY, like BCM54616, can be validated.
Applies to the five platforms below, that have the ethernet controller
BCM5720:
as7116_54x, as7326_56x, as7716_32x-r0, as7716_32xb, and as7816_64x
Verified by mii-tool. (31 is the address of external phy).
root@sonic:/home/admin# mii-tool -v eth0 -p 31
using the specified MII index 31.
eth0: negotiated, link ok
product info: vendor 00:d8:97, model 17 rev 2
basic mode: autonegotiation enabled
basic status: autonegotiation complete, link ok
capabilities: 1000baseT-HD 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD
advertising: flow-control
link partner: 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD
Note, this upstreams a patch to the SONiC Linux kernel added in 2018
[1][2][3].
[1]: sonic-net/sonic-linux-kernel#71
[2]: sonic-net/sonic-linux-kernel@ad754bd
[3]: sonic-net/sonic-buildimage#2318
Signed-off-by: Roy Lee <[email protected]>
Signed-off-by: Paul Menzel <[email protected]>
Signed-off-by: NipaLocal <nipa@local>
kuba-moo
pushed a commit
to linux-netdev/testing
that referenced
this pull request
Aug 2, 2024
Add parameter to enable *short preamble* for MAC, so MDIO access to some
external PHY, like BCM54616, can be validated.
Applies to the five platforms below, that have the ethernet controller
BCM5720:
as7116_54x, as7326_56x, as7716_32x-r0, as7716_32xb, and as7816_64x
Verified by mii-tool. (31 is the address of external phy).
root@sonic:/home/admin# mii-tool -v eth0 -p 31
using the specified MII index 31.
eth0: negotiated, link ok
product info: vendor 00:d8:97, model 17 rev 2
basic mode: autonegotiation enabled
basic status: autonegotiation complete, link ok
capabilities: 1000baseT-HD 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD
advertising: flow-control
link partner: 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD
Note, this upstreams a patch to the SONiC Linux kernel added in 2018
[1][2][3].
[1]: sonic-net/sonic-linux-kernel#71
[2]: sonic-net/sonic-linux-kernel@ad754bd
[3]: sonic-net/sonic-buildimage#2318
Signed-off-by: Roy Lee <[email protected]>
Signed-off-by: Paul Menzel <[email protected]>
Signed-off-by: NipaLocal <nipa@local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 2 kernel cmdline, tg3.short_preamble=1 tg3.bcm5718s_reset=1, to validate mdio acccess to external PHY.
For some accton platforms are equipped BCM5720 as MAC chip of their management port.
Change kernel driver, tg3, to support "short preamble" feature of BCM5720.
These change needs also kernel patching, sonic-net/sonic-linux-kernel#71.
Signed-off-by: roy_lee [email protected]
- What I did
Bring kernel cmdline to support short_preamble and bcm5718s_reset.
For accton platforms with ethernet controller, BCM5720.
Total 5 platforms:
as7116_54x, as7326_56x, as7716_32x-r0, as7716_32xb, and as7816_64x.
- How I did it
Add extra kernel cmdline to installer.conf on these platforms.
- How to verify it
Verified by mii-tool. (31 is the address of external phy).
root@sonic:/home/admin# mii-tool -v eth0 -p 31
using the specified MII index 31.
eth0: negotiated, link ok
product info: vendor 00:d8:97, model 17 rev 2
basic mode: autonegotiation enabled
basic status: autonegotiation complete, link ok
capabilities: 1000baseT-HD 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD
advertising: flow-control
link partner: 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD