Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lldpd]: Use kernel autoprobe for netlink socket .nl_pid portion of the address #2164

Merged
merged 1 commit into from
Oct 18, 2018
Merged

[lldpd]: Use kernel autoprobe for netlink socket .nl_pid portion of the address #2164

merged 1 commit into from
Oct 18, 2018

Conversation

pavel-shirshov
Copy link
Contributor

- What I did
I added a patch to fix lldpd issue lldpd[24]: unable to bind netlink socket: Address already in use.

- How I did it
Netlink sockets doesn't support Linux kernel namespaces. So every netlink socket is created in a global namespace.
Traditionally, when netlink socket is created, the current process pid is used in nl_pid portion of the socket address. When we use docker environment, we could have a lot of processes with the same pid number, but in different docker containers. When we have two processes which create a netlink socket with get_pid() as its address it will create "Address already in use error" error for the second process. To avoid it, it's better to use .nl_pid = 0 which allows us to avoid such error by autoprobing the most appropriate address.

- How to verify it
Build lldp with the patch. Start one lldp process in one docker and another lldp process in another docker. Please make sure that both processes uses the same pid.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@pavel-shirshov pavel-shirshov self-assigned this Oct 17, 2018
@lguohan lguohan merged commit 891e256 into master Oct 18, 2018
lguohan pushed a commit that referenced this pull request Oct 18, 2018
@pavel-shirshov @lguohan
[lldpd]: Use kernel autoprobe for netlink socket .nl_pid portion of t…
969ba5b 
…he address (#2164)
@stcheng stcheng deleted the pavelsh/lldp_pid branch October 19, 2018 07:35
@pavel-shirshov pavel-shirshov mentioned this pull request Oct 20, 2018
Merged
judyjoseph added a commit that referenced this pull request Mar 20, 2022
@judyjoseph
Update sonic-swss
62283df 
6a6b711 (HEAD -> 202111, origin/202111) Fix issue: sometimes PFC WD unable to create zero buffer pool (#2164)
459aee0 Use abort instead of exit in case calling SAI API failure (#2170)
e767137 Fix issue config qos reload causing orchagent aborted via tracking dependencies among QoS tables (#2116)
liorghub added a commit to liorghub/sonic-buildimage that referenced this pull request Mar 23, 2022
@liorghub
[sonic-swss]: Advance submodule
967bbef 
Update sonic-swss submodule to include below commits:
d80094b [aclorch] Do not fail ACL rule remove flow if rule already deleted (sonic-net#2183)
bea0b70 [gcov]: Change coverage.xml file references (sonic-net#2120)
829b219 [tunnelmgrd]: Warm boot support (sonic-net#2166)
ad65b0a Fix issue: sometimes PFC WD unable to create zero buffer pool (sonic-net#2164)
608acc3 [doc] Moving Configuration.md from swss to yang sub-folder (sonic-net#2177)
0294376 [orchagent] NVGRE Tunnel orchestration agent implementation (sonic-net#1953)
ce88696 [ci] Update default sonic image downloading build ID. (sonic-net#2175)
@liorghub liorghub mentioned this pull request Mar 23, 2022
Merged
6 tasks
liat-grozovik pushed a commit that referenced this pull request Mar 29, 2022
@liorghub
[sonic-swss]: Advance submodule (#10332)
f054d07 
Update sonic-swss submodule to include below commits:
d80094b [aclorch] Do not fail ACL rule remove flow if rule already deleted (#2183)
bea0b70 [gcov]: Change coverage.xml file references (#2120)
829b219 [tunnelmgrd]: Warm boot support (#2166)
ad65b0a Fix issue: sometimes PFC WD unable to create zero buffer pool (#2164)
608acc3 [doc] Moving Configuration.md from swss to yang sub-folder (#2177)
0294376 [orchagent] NVGRE Tunnel orchestration agent implementation (#1953)
ce88696 [ci] Update default sonic image downloading build ID. (#2175)

Co-authored-by: liora <[email protected]>
Ndancejic pushed a commit to Ndancejic/sonic-buildimage that referenced this pull request May 3, 2022
@stephenxs
Fix issue: sometimes PFC WD unable to create zero buffer pool (sonic-…
ad65b0a 
…net#2164)

What I did
Fix issue: sometimes PFC WD is unable to create zero buffer pool.
On some platforms, an ingress/egress zero buffer profile will be applied on the PG and queue which are under PFC storm. The zero buffer profile is created based on zero buffer pool. However, sometimes it fails to create zero buffer pool due to too many buffer pools existing in the system.
Sometimes, there is a zero buffer pool existing on the system for reclaiming buffer. In that case, we can leverage it to create zero buffer profile for PFC WD.

Why I did it
Fix the issue via sharing the zero buffer pool between PFC WD and buffer orchagent

How I verified it
Manually test
Run PFC WD test and PFC WD warm reboot test
Run unit test

Details if related
The detailed flow is like this:

PFC Storm detected:
If there is a zero pool in PFC WD's cache, just create the zero buffer profile based on it
Otherwise, fetching the zero pool from buffer orchagent
If got one, create the zero buffer profile based on it
Otherwise,
create a zero buffer pool
notify the zero buffer pool about the buffer orch
In both cases, PFC WD should notify buffer orch to increase the reference number of the zero buffer pool.

Buffer orchagent:
When creating the zero buffer pool,
check whether there is one. if yes, skip the SAI API create_buffer_pool
increase the reference number.
Before removing the zero buffer pool, decrease and check the reference number. if it is zero (after decreased), skip SAI API destroy_buffer_pool.
When PFC WD decrease reference number: remove the zero buffer pool if the reference number becomes zero

Notes
We do not leverage the object_reference_map infrastructure to track the dependency because:
it assumes the dependency will eventually be removed if an object is removed. that's NOT true in this scenario because the PFC storm can last for a relatively long time and even cross warm reboot.
the interfaces differ.

Signed-off-by: Stephen Sun <[email protected]>
@SuvarnaMeenakshi SuvarnaMeenakshi mentioned this pull request Jul 5, 2022
Merged
7 tasks
SuvarnaMeenakshi added a commit that referenced this pull request Jul 6, 2022
@SuvarnaMeenakshi
[sonic-utilities]: Advance submodule (#11344)
94f9f9c 
Update sonic-utilities submodule to include below commits:
7070794 Fix DBConfig not initialize issue in pfcwd (#2238)
b5d6659 [config/load_mgmt_config] Support load IPv6 mgmt IP (#2206)
3274b0e Added bf_drivers.log to zipped dump after execution of "show techsupport" (#2164)
8dee36c [portstat] Update portstat to use CounterTable API (#2207)
7d9faf3 Added support for Sonic cross-compilation build. (#2233)
c3620fc [GCU] Moving UniqueLanes from only validating moves, to be a supplemental YANG validator (#2234)
Signed-off-by: Suvarna Meenakshi <[email protected]>
vivekrnv added a commit to vivekrnv/sonic-buildimage that referenced this pull request Aug 26, 2022
@vivekrnv
[PFC_WD] Avoid applying ZeroBuffer Profiles to ingress PG when a PFC …
93af69c 
…storm is detected (sonic-net#2304)

What I did
Avoid dropping traffic that is ingressing the port/pg that is in storm. The code changes in this PR avoid creating the ingress zero pool and profile and does not attach any zero profile to the ingress pg when pfcwd is triggered

Revert changes related to sonic-net#1480 where the retry mechanism was added to BufferOrch which caches the task retries and while the PG is locked by PfcWdZeroBufferHandler.

Revert changes related to sonic-net#2164 in PfcWdZeroBufferHandler & ZeroBufferProfile & BufferOrch.

Updated UT's accordingly

How I verified it
UT's.
Ran the sonic-mgmt test with these changes sonic-net/sonic-mgmt#5665 and verified if they've passed.

Signed-off-by: Vivek Reddy Karri <[email protected]>
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Sep 23, 2022
@yxieca
Merged PR 6324192: Manual merge github master into internal branch
002411d 
Related work items: sonic-net#284, sonic-net#288, sonic-net#624, sonic-net#630, sonic-net#640, sonic-net#2164, sonic-net#2206, sonic-net#2207, sonic-net#2233, sonic-net#2234, sonic-net#2238, sonic-net#8857, sonic-net#10034, sonic-net#10519, sonic-net#10685, sonic-net#10711, sonic-net#10987, sonic-net#10990, sonic-net#11047, sonic-net#11070, sonic-net#11117, sonic-net#11186, sonic-net#11207, sonic-net#11213, sonic-net#11215, sonic-net#11220, sonic-net#11221, sonic-net#11257, sonic-net#11291, sonic-net#11298, sonic-net#11301, sonic-net#11326, sonic-net#11333, sonic-net#11335, sonic-net#11341, sonic-net#11344, sonic-net#11347, sonic-net#11359, sonic-net#11366, sonic-net#11368, sonic-net#11370, sonic-net#11372, sonic-net#11375, sonic-net#11385, sonic-net#11386, sonic-net#11394, sonic-net#11397, sonic-net#11401, sonic-net#11402, sonic-net#11403, sonic-net#11405, sonic-net#11414
@aravindmani-1 aravindmani-1 mentioned this pull request Nov 18, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleveque jleveque jleveque approved these changes

@lguohan lguohan lguohan approved these changes

Assignees

@pavel-shirshov pavel-shirshov

Labels
Bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavel-shirshov @lguohan @jleveque