-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[yang]: Add yang models for table BGP_ALLOWED_PREFIXES #10142
[yang]: Add yang models for table BGP_ALLOWED_PREFIXES #10142
Conversation
@wen587 I verified this on master image, looks ok now, the reason is that the previous key pattern is wrong, I use "prefixs_p4", now it works. admin@str-s6000-acs-11: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please wait for other reviewer's approval.
} | ||
|
||
leaf community { | ||
type string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does community have any pattern? 123:123?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ganglyu good catch, I found there are at least 2 different formats for community id, one is 4 bytes, the other is 2 bytes:2bytes, I took a reference from existing yang model files, all of them take string as the type of community and no pattern enforcement.
As you suggested, I think we should put a enforcement for the community id for all cases, filed an issue to track this, address this may beyond the scope of this PR.
#10145
Why I did it
end2end test is blocked by Yang model for BGP allowed prefix list.
How I did it
Create new yang files for BGP allowed prefix list, and add UT.
How to verify it
Run UT for sonic-yang-models.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)
Fix: #9866