Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCU test for BGP prefix #5268

Merged
merged 5 commits into from
Mar 14, 2022
Merged

GCU test for BGP prefix #5268

merged 5 commits into from
Mar 14, 2022

Conversation

wen587
Copy link
Contributor

@wen587 wen587 commented Mar 2, 2022

Description of PR

[Done]Wait for yang model sonic-net/sonic-buildimage#10142
[Done]Wait for issue fix: sonic-net/sonic-buildimage#10141
Summary: Testcase of bgp allowed prefix config for generic updater apply-patch
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012

Approach

What is the motivation for this PR?

End to End test support for Generic Updater apply-patch
This PR is to verify the usage of 'config apply-patch' works on bgp allowed prefix config

How did you do it?

Add bgp prefix config to dut and check if config change as expected

How did you verify/test it?

Run test of sonic-mgmt/tests/generic_config_updater/test_bgp_prefix.py on KVM

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@wen587 wen587 marked this pull request as ready for review March 2, 2022 06:56
@wen587 wen587 requested a review from a team as a code owner March 2, 2022 06:56
@ganglyu ganglyu requested a review from StormLiangMS March 2, 2022 07:31
from tests.generic_config_updater.gu_utils import create_checkpoint, delete_checkpoint, rollback_or_reload

pytestmark = [
pytest.mark.topology('t0'), #TODO: t0?
Copy link

@ghooo ghooo Mar 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think T0s should be enough This should be T1.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link

@ghooo ghooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check open comment

from tests.generic_config_updater.gu_utils import create_checkpoint, delete_checkpoint, rollback_or_reload

pytestmark = [
pytest.mark.topology('t0'), #TODO: t0?
Copy link
Contributor

@qiluo-msft qiluo-msft Mar 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#TODO: t0

The TODO comment does not make sense. You already covered t0. #Closed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Contributor

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please check with other reviewers.

@wen587 wen587 merged commit 14ea26f into sonic-net:master Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GCU or bgpcfgd]bgp prefix updating only fail for prefixes_v4 removal when GCU apply-patch
3 participants