This repository has been archived by the owner on Jul 28, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 198
Fix phpunit #625
Merged
Merged
Fix phpunit #625
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,9 +9,7 @@ | |
> | ||
|
||
<php> | ||
<ini name="error_reporting" value="-1" /> | ||
<server name="KERNEL_CLASS" value="AppKernel" /> | ||
<env name="SYMFONY_DEPRECATIONS_HELPER" value="weak"/> | ||
<server name="KERNEL_CLASS" value="App\Kernel" /> | ||
|
||
<!-- ###+ doctrine/doctrine-bundle ### --> | ||
<!-- Format described at https://www.doctrine-project.org/projects/doctrine-dbal/en/latest/reference/configuration.html#connecting-using-a-url --> | ||
|
@@ -42,34 +40,6 @@ | |
</testsuite> | ||
</testsuites> | ||
|
||
<!-- | ||
<php> | ||
<server name="KERNEL_DIR" value="/path/to/your/app/" /> | ||
|
||
<!-- ###+ doctrine/doctrine-bundle ### --> | ||
<!-- Format described at https://www.doctrine-project.org/projects/doctrine-dbal/en/latest/reference/configuration.html#connecting-using-a-url --> | ||
<!-- For an SQLite database, use: "sqlite:///%kernel.project_dir%/var/data.db" --> | ||
<!-- For a PostgreSQL database, use: "postgresql://db_user:[email protected]:5432/db_name?serverVersion=11&charset=utf8" --> | ||
<!-- IMPORTANT: You MUST configure your server version, either here or in config/packages/doctrine.yaml --> | ||
<env name="DATABASE_URL" value="mysql://db_user:[email protected]:3306/db_name?serverVersion=5.7"/> | ||
<!-- ###- doctrine/doctrine-bundle ### --> | ||
|
||
<!-- ###+ symfony/swiftmailer-bundle ### --> | ||
<!-- For Gmail as a transport, use: "gmail://username:password@localhost" --> | ||
<!-- For a generic SMTP server, use: "smtp://localhost:25?encryption=&auth_mode=" --> | ||
<!-- Delivery is disabled by default via "null://localhost" --> | ||
<env name="MAILER_URL" value="null://localhost"/> | ||
<!-- ###- symfony/swiftmailer-bundle ### --> | ||
|
||
<!-- ###+ symfony/framework-bundle ### --> | ||
<env name="APP_ENV" value="dev"/> | ||
<env name="APP_SECRET" value="925b958e51a78ee7a9edd86cf9778089"/> | ||
<!-- env name="TRUSTED_PROXIES" value="127.0.0.0/8,10.0.0.0/8,172.16.0.0/12,192.168.0.0/16" --> | ||
<!-- env name="TRUSTED_HOSTS" value="'^(localhost|example\.com)$'" --> | ||
<!-- ###- symfony/framework-bundle ### --> | ||
</php> | ||
--> | ||
|
||
<filter> | ||
<whitelist> | ||
<directory>../src</directory> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would prefer
Sonata\Tests
overTests\Sonata
because the vendor is SonataThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want create sandbox as predefine application, ready to use where people can modify them. I replace tests becouse it is default directory for it. I think will be nice use
Tests\Sonata
withoutBundle\QABundle
, mybe even split it to seperate namespace likeTests\Sonata\News
. I prefer usingTest\Sonata
becouse people can delete them without change in composer.json (this change require usecomposer update
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, should we merge QABundle with DemoBundle?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@core23 @wbloszyk
You can do
and then
tests/Bundle/QABundle/...
, without theSonata
folder.isn't it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want avoid modify composer.json becouse if people delete tests then they have to remove it from composer.json too and run
composer update
to clear it on vendor/composer files.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO having standard composer .json namespaces is better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO files from vendor directory should be trait as sonata files. Files from other directory should be trait as people files to keep it as easy is possible to edit. I dont think user will want edit composer after remove files.
@VincentLanglet What when someone add own tests? Then namespace
Sonata\Tests
will be require.@VincentLanglet @core23 @jordisala1991 WDYT?
My sugestion is:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a sandbox project. We should risk this and follow vendor-prefixed namespaces (
Sonata\Tests
).