Fix phpunit

[wbloszyk]

This PR will allow run phpunit test by:

vendor/bin/simple-phpunit
bin/qa_client_ci.sh

[jordisala1991]

Those TODOS need to be fixed before merging tho

[wbloszyk]

Probably fixed TODOS before merging is impossible. They depends from other sonata bundles. I can remove them but this will suspended tests. I think better keep it working becouse they show deprecations and bugs (like this TODOS) which should be fixed.

[jordisala1991]

Better to have something working

[core23]

Would prefer Sonata\Tests over Tests\Sonata because the vendor is Sonata

[wbloszyk]

I want create sandbox as predefine application, ready to use where people can modify them. I replace tests becouse it is default directory for it. I think will be nice use Tests\Sonata without Bundle\QABundle, mybe even split it to seperate namespace like Tests\Sonata\News. I prefer using Test\Sonata becouse people can delete them without change in composer.json (this change require use composer update).

"autoload-dev": {
    "psr-4": {
        "Tests\\": "tests/"
    }
},

[wbloszyk]

BTW, should we merge QABundle with DemoBundle?

[VincentLanglet]

@core23 @wbloszyk

You can do

"autoload-dev": {
    "psr-4": {
        "Sonata\\Tests\\": "tests/"
    }
},

and then tests/Bundle/QABundle/..., without the Sonata folder.

isn't it ?

[wbloszyk]

I want avoid modify composer.json becouse if people delete tests then they have to remove it from composer.json too and run composer update to clear it on vendor/composer files.

[jordisala1991]

IMO having standard composer .json namespaces is better.

[wbloszyk]

IMO files from vendor directory should be trait as sonata files. Files from other directory should be trait as people files to keep it as easy is possible to edit. I dont think user will want edit composer after remove files.

@VincentLanglet What when someone add own tests? Then namespace Sonata\Tests will be require.

@VincentLanglet @core23 @jordisala1991 WDYT?
My sugestion is:

1. move AppBundle to src (App)
2. move QABundle to DemoBundle
3. split DemoBundle to DemoBundle and sonata-project instalator packege/bundle
4. improve DemoBundle

[core23]

[...] if people delete tests then they have to remove it from composer.json too and run composer update to clear it on vendor/composer files.

This is a sandbox project. We should risk this and follow vendor-prefixed namespaces (Sonata\Tests).

[wbloszyk]

RTM

[wbloszyk]

@core23 @VincentLanglet Can you recheck it?

[jordisala1991]

Thank you @wbloszyk