Poc to reuse MenuBlock #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| ]], | ||
| ['context', TextType::class, [ | ||
| 'required' => false, | ||
| 'label' => 'form.label_context', // TODO |
There was a problem hiding this comment.
Those 3 translations are missing, do you plan to add them on this PR?
There was a problem hiding this comment.
Translations are added
jordisala1991
previously approved these changes
Sep 26, 2022
VincentLanglet
force-pushed
the
pocMenuBlock
branch
from
276bdf3 to
1df6da8
Compare
|
Should we release this as a patch or a minor @jordisala1991 ? |
|
Minor I would say |
Ok ! Just waiting for your review when you have time :) |
jordisala1991
approved these changes
Sep 28, 2022
jordisala1991
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because {reason}.
Closes #{put_issue_number_here}.
Changelog