Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poc to reuse MenuBlock #1612

Merged
merged 6 commits into from
Sep 28, 2022
Merged

Poc to reuse MenuBlock #1612

merged 6 commits into from
Sep 28, 2022

Conversation

VincentLanglet
Copy link
Member

@VincentLanglet VincentLanglet commented Sep 17, 2022 •
edited
Loading

Subject

I am targeting this branch, because {reason}.

Closes #{put_issue_number_here}.

@VincentLanglet VincentLanglet mentioned this pull request Sep 17, 2022
Closed
@jordisala1991
Copy link
Member

This should also be reverted:

SonataPageBundle/src/Resources/config/block.php

Line 47 in 01f5a86

new ReferenceConfigurator('sonata.block.service.menu'),

@VincentLanglet
Copy link
Member Author

VincentLanglet commented Sep 17, 2022 •
edited
Loading

This should also be reverted:

SonataPageBundle/src/Resources/config/block.php

Line 47 in 01f5a86

new ReferenceConfigurator('sonata.block.service.menu'),

Test are not failing ^^'

Are you talking about this revert https://github.com/sonata-project/SonataPageBundle/pull/1612/files#diff-b50ae12595c81d84839724f494ff3fc84c2c4bfac81990d3e14c87ecc3459ce2L47 ?

@jordisala1991
Copy link
Member

This should also be reverted:

SonataPageBundle/src/Resources/config/block.php

Line 47 in 01f5a86

new ReferenceConfigurator('sonata.block.service.menu'),

Test are not failing ^^'

Are you talking about this revert https://github.com/sonata-project/SonataPageBundle/pull/1612/files#diff-b50ae12595c81d84839724f494ff3fc84c2c4bfac81990d3e14c87ecc3459ce2L47 ?

Yes, if you are not passing the block on the parent, how is this working?

@VincentLanglet
Copy link
Member Author

Yes, if you are not passing the block on the parent, how is this working?

I don't understand, I remove the constructor param https://github.com/sonata-project/SonataPageBundle/pull/1612/files#diff-f0461df8f4a53195f2b565ad37746df1e8076ff748edb18c3e2689581f2db4caL40 so I also remove in the config.

Now the block is extending BaseBreadcrumbService in which the constructor signature is reverted by
sonata-project/SonataSeoBundle#692

@jordisala1991
Copy link
Member

@VincentLanglet I tried this PR (that uses at the same time the 3 PRs and everything seems fine).

@SonataCI
Copy link
Collaborator

Could you please rebase your PR and fix merge conflicts?

@VincentLanglet VincentLanglet mentioned this pull request Sep 28, 2022
Closed
36 tasks
@VincentLanglet VincentLanglet marked this pull request as ready for review September 28, 2022 20:25
jordisala1991
jordisala1991 reviewed Sep 28, 2022
View reviewed changes
src/Block/ChildrenPagesBlockService.php
@@ -123,23 +123,28 @@ public function configureEditForm(FormMapper $form, BlockInterface $block): void
['title', TextType::class, [
'required' => false,
'label' => 'form.label_title',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this line one space off?

@VincentLanglet VincentLanglet merged commit ea64eac into 4.x Sep 28, 2022
@VincentLanglet VincentLanglet deleted the pocMenuBlock branch September 28, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordisala1991 jordisala1991 jordisala1991 approved these changes

Assignees
No one assigned
Labels
major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VincentLanglet @jordisala1991 @SonataCI