Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing stylesheets and javascripts options from sonata_page #1596

Merged
merged 3 commits into from
Sep 8, 2022
Merged

Removing stylesheets and javascripts options from sonata_page #1596

merged 3 commits into from
Sep 8, 2022

Conversation

eerison
Copy link
Contributor

@eerison eerison commented Sep 7, 2022 •
edited
Loading

Removing stylesheets and javascripts options from sonata_page

I am targeting this branch, because It was deprecated in 3.x and should be removed in 4.x.

Changelog

### Removed
- Removed `sonata.page.assets` option

@eerison
Copy link
Contributor Author

eerison commented Sep 7, 2022

it's blocked by #1595

@SonataCI
Copy link
Collaborator

SonataCI commented Sep 7, 2022

Could you please rebase your PR and fix merge conflicts?

@eerison
Merge branch '4.x' of https://github.com/sonata-project/SonataPageBundle
3a1574e 
 into Remove_stylesheets_and_javascript_options

� Conflicts:
�	UPGRADE-4.0.md
@eerison
Removed some assets config
b4f011d
@eerison eerison marked this pull request as ready for review September 8, 2022 07:18
@eerison eerison mentioned this pull request Sep 8, 2022
Closed
36 tasks
@VincentLanglet VincentLanglet merged commit 10550c6 into sonata-project:4.x Sep 8, 2022
@eerison eerison deleted the Remove_stylesheets_and_javascript_options branch September 8, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet approved these changes

@jordisala1991 jordisala1991 jordisala1991 approved these changes

Assignees
No one assigned
Labels
major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eerison @SonataCI @jordisala1991 @VincentLanglet