Deprecated assets option #1595
Merged
Deprecated assets option #1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jordisala1991 I didn't see this options be used anymore in 4.x, then we should just remove on 4.x? |
eerison
force-pushed
the
Deprecate_assets_option
branch
from
cb87c98 to
8129d46
Compare
|
no idea why the pipelines are failing :( |
Linter will always fail on 3.x now since it can't install latest versions. Don't worry |
VincentLanglet
previously approved these changes
Sep 6, 2022
ahhhh now, I got it, the app.js/app.css is used in sonata_admin configs ... yeah make sense to remove this |
VincentLanglet
approved these changes
Sep 7, 2022
jordisala1991
approved these changes
Sep 7, 2022
|
Thanks @eerison |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate assets option
I am targeting this branch, because it won't be useful anymore in the next major.
Changelog