Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snapshot resname & source #1539

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Update snapshot resname & source #1539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eeddf30
Update snapshot resname & source
Aug 10, 2022
76a45e8
Update snapshot source
Aug 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Resources/translations/SonataPageBundle.bg.xliff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,8 @@
<source>sidemenu.link_list_snapshots</source>
<target>Публикации</target>
</trans-unit>
<trans-unit id="90" resname="snapshot">
<source>snapshot</source>
<trans-unit id="90" resname="form.group_snapshot">
<source>form.group_snapshot</source>
<target>Публикации</target>
</trans-unit>
<trans-unit id="91" resname="sonata_page">
Expand Down
4 changes: 2 additions & 2 deletions src/Resources/translations/SonataPageBundle.de.xliff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,8 @@
<source>sidemenu.link_list_snapshots</source>
<target>Publikationen</target>
</trans-unit>
<trans-unit id="90" resname="snapshot">
<source>snapshot</source>
<trans-unit id="90" resname="form.group_snapshot">
<source>form.group_snapshot</source>
<target>Publikationen</target>
</trans-unit>
<trans-unit id="91" resname="sonata_page">
Expand Down
4 changes: 2 additions & 2 deletions src/Resources/translations/SonataPageBundle.en.xliff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,8 @@
<source>sidemenu.link_list_snapshots</source>
<target>Publications</target>
</trans-unit>
<trans-unit id="90" resname="snapshot">
<source>snapshot</source>
<trans-unit id="90" resname="form.group_snapshot">
<source>form.group_snapshot</source>
<target>Publications</target>
Copy link
Contributor

@eerison eerison Aug 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well It was a thing that confusing me, Here says publications but in the code uses snapshot,

Don't you think, we should use Snapshots instead of Publications?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VincentLanglet @jordisala1991

Copy link
Contributor

@eerison eerison Aug 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But to translate for others languages I guess publication make more sense :/

I don't know, what do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be done on another PR. What word does the user undestand more, publications or snapshots? I think snapshot is more technical word, but not sure, because I have never used this bundle.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I guess it can be handled in other PR!

</trans-unit>
<trans-unit id="91" resname="sonata_page">
Expand Down
4 changes: 2 additions & 2 deletions src/Resources/translations/SonataPageBundle.es.xliff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,8 @@
<source>sidemenu.link_list_snapshots</source>
<target>Impresiones</target>
</trans-unit>
<trans-unit id="90" resname="snapshot">
<source>snapshot</source>
<trans-unit id="90" resname="form.group_snapshot">
<source>form.group_snapshot</source>
<target>Impresiones</target>
</trans-unit>
<trans-unit id="91" resname="sonata_page">
Expand Down
4 changes: 2 additions & 2 deletions src/Resources/translations/SonataPageBundle.fr.xliff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,8 @@
<source>sidemenu.link_list_snapshots</source>
<target>Publications</target>
</trans-unit>
<trans-unit id="90" resname="snapshot">
<source>snapshot</source>
<trans-unit id="90" resname="form.group_snapshot">
<source>form.group_snapshot</source>
<target>Publications</target>
</trans-unit>
<trans-unit id="91" resname="sonata_page">
Expand Down
4 changes: 2 additions & 2 deletions src/Resources/translations/SonataPageBundle.hu.xliff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,8 @@
<source>sidemenu.link_list_snapshots</source>
<target>Publikációk</target>
</trans-unit>
<trans-unit id="90" resname="snapshot">
<source>snapshot</source>
<trans-unit id="90" resname="form.group_snapshot">
<source>form.group_snapshot</source>
<target>Publikációk</target>
</trans-unit>
<trans-unit id="91" resname="sonata_page">
Expand Down
4 changes: 2 additions & 2 deletions src/Resources/translations/SonataPageBundle.it.xliff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,8 @@
<source>sidemenu.link_list_snapshots</source>
<target>Pubblicazioni</target>
</trans-unit>
<trans-unit id="90" resname="snapshot">
<source>snapshot</source>
<trans-unit id="90" resname="form.group_snapshot">
<source>form.group_snapshot</source>
<target>Pubblicazioni</target>
</trans-unit>
<trans-unit id="91" resname="sonata_page">
Expand Down
4 changes: 2 additions & 2 deletions src/Resources/translations/SonataPageBundle.ja.xliff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,8 @@
<source>sidemenu.link_list_snapshots</source>
<target>公開</target>
</trans-unit>
<trans-unit id="90" resname="snapshot">
<source>snapshot</source>
<trans-unit id="90" resname="form.group_snapshot">
<source>form.group_snapshot</source>
<target>公開</target>
</trans-unit>
<trans-unit id="91" resname="sonata_page">
Expand Down
4 changes: 2 additions & 2 deletions src/Resources/translations/SonataPageBundle.nl.xliff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,8 @@
<source>sidemenu.link_list_snapshots</source>
<target>Momentopnames</target>
</trans-unit>
<trans-unit id="90" resname="snapshot">
<source>snapshot</source>
<trans-unit id="90" resname="form.group_snapshot">
<source>form.group_snapshot</source>
<target>Momentopname</target>
</trans-unit>
<trans-unit id="91" resname="sonata_page">
Expand Down
4 changes: 2 additions & 2 deletions src/Resources/translations/SonataPageBundle.pt_BR.xliff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,8 @@
<source>sidemenu.link_list_snapshots</source>
<target>Publicações</target>
</trans-unit>
<trans-unit id="90" resname="snapshot">
<source>snapshot</source>
<trans-unit id="90" resname="form.group_snapshot">
<source>form.group_snapshot</source>
<target>Publicação</target>
</trans-unit>
<trans-unit id="91" resname="sonata_page">
Expand Down
4 changes: 2 additions & 2 deletions src/Resources/translations/SonataPageBundle.ru.xliff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,8 @@
<source>sidemenu.link_list_snapshots</source>
<target>Публикации</target>
</trans-unit>
<trans-unit id="90" resname="snapshot">
<source>snapshot</source>
<trans-unit id="90" resname="form.group_snapshot">
<source>form.group_snapshot</source>
<target>Публикации</target>
</trans-unit>
<trans-unit id="91" resname="sonata_page">
Expand Down
4 changes: 2 additions & 2 deletions src/Resources/translations/SonataPageBundle.sk.xliff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,8 @@
<source>sidemenu.link_list_snapshots</source>
<target>Publikácie</target>
</trans-unit>
<trans-unit id="90" resname="snapshot">
<source>snapshot</source>
<trans-unit id="90" resname="form.group_snapshot">
<source>form.group_snapshot</source>
<target>Publikácie</target>
</trans-unit>
<trans-unit id="91" resname="sonata_page">
Expand Down
4 changes: 2 additions & 2 deletions src/Resources/translations/SonataPageBundle.sl.xliff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,8 @@
<source>sidemenu.link_list_snapshots</source>
<target>Članki</target>
</trans-unit>
<trans-unit id="90" resname="snapshot">
<source>snapshot</source>
<trans-unit id="90" resname="form.group_snapshot">
<source>form.group_snapshot</source>
<target>Članki</target>
</trans-unit>
<trans-unit id="91" resname="sonata_page">
Expand Down