Update snapshot resname & source #1539
Conversation
| <trans-unit id="90" resname="snapshot"> | ||
| <source>snapshot</source> | ||
| <trans-unit id="90" resname="form.group_snapshot"> | ||
| <source>form.group_snapshot</source> | ||
| <target>Publications</target> |
There was a problem hiding this comment.
Well It was a thing that confusing me, Here says publications but in the code uses snapshot,
Don't you think, we should use Snapshots instead of Publications?
There was a problem hiding this comment.
There was a problem hiding this comment.
But to translate for others languages I guess publication make more sense :/
I don't know, what do you think?
There was a problem hiding this comment.
I think it should be done on another PR. What word does the user undestand more, publications or snapshots? I think snapshot is more technical word, but not sure, because I have never used this bundle.
There was a problem hiding this comment.
Yeah I guess it can be handled in other PR!
| @@ -358,7 +358,7 @@ | |||
| <source>sidemenu.link_list_snapshots</source> | |||
| <target>Publikationen</target> | |||
| </trans-unit> | |||
| <trans-unit id="90" resname="snapshot"> | |||
| <trans-unit id="90" resname="form.group_snapshot"> | |||
| <source>snapshot</source> | |||
There was a problem hiding this comment.
I think you should modify the sources for all cases. TBH not sure what is "resname"
There was a problem hiding this comment.
We can remove "resname" and put them instead of id numbers like SonataAdminBundle.
Should I change in this PR or better to create a PR for all translations SonataPageBundle files?
There was a problem hiding this comment.
If you can do it in separate PRs it would be nice.
There was a problem hiding this comment.
Sure, will do that 🙂
There was a problem hiding this comment.
Even if we do in a separate PRs, here we should fix the <source> field of translations.
| @@ -358,7 +358,7 @@ | |||
| <source>sidemenu.link_list_snapshots</source> | |||
| <target>Публикации</target> | |||
| </trans-unit> | |||
| <trans-unit id="90" resname="snapshot"> | |||
| <trans-unit id="90" resname="form.group_snapshot"> | |||
| <source>snapshot</source> | |||
There was a problem hiding this comment.
source must be modified too
There was a problem hiding this comment.
ah.. first I only updated source on en file. Done 👍
|
Thanks @Amin-Hosseini |
Update Snapshot source
Issues #1495