-
-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace PageableManagerInterface in favor for PageableInterface #1916
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why the typehint are added/needed ?
Becouse |
|
When we change using |
Co-authored-by: Javier Spagnoletti <[email protected]>
Co-authored-by: Javier Spagnoletti <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, breaking the signature of public methods is considered a BC break.
Is there a strong reason to introduce this break in 3.x
?
Probably of overriding these mehods are very low. I want to reduce deprecation. I can also move this PR to master and do not display deprecations if people do not override it. |
If this is a blocking point for some needed support/fixing something. We could think about it. |
Close in favor of #1925 |
Subject
I am targeting this branch, because this change should be done here. They provide little BC-break.
Closes #1871.
Changelog