-
-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MediaManager.php #1871
Update MediaManager.php #1871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @mrcmorales!
Could you please add a test in order to avoid regressions?
Can we still merge this @phansys ? It would be nice to avoid blocking a bugfix like this. |
Do we need tests that a class contains some interface? oO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we still merge this @phansys ? It would be nice to avoid blocking a bugfix like this.
Sure, we could add some tests later.
Do we need tests that a class contains some interface? oO
If this is considered as bugfix, I think so. A call to assertInstanceOf()
should be enough IMO.
A test should cover behavior not the design of a class. |
Subject
I am targeting this branch, because {reason}.
Closes #1870.
Changelog