Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for symfony 5 #278

Closed
wants to merge 4 commits into from
Closed

Conversation

core23
Copy link
Member

@core23 core23 commented Dec 6, 2019

Subject

I am targeting this branch, because this is BC.

Changelog

### Added
- Added support for symfony 5

### Removed
- Dropped support for PHP 7.1

@core23 core23 added the minor label Dec 6, 2019
@core23 core23 force-pushed the symfony5 branch 3 times, most recently from 81f5c73 to 605856f Compare December 6, 2019 21:40
@core23
Copy link
Member Author

core23 commented Dec 6, 2019

We need PHPUnit 8 to make this pass :/

@franmomu
Copy link
Member

franmomu commented Dec 7, 2019

We need PHPUnit 8 to make this pass :/

yep, in twig-extensions was the same thing

@OskarStark
Copy link
Member

But it looks like Travis is still red with PHPUnit 8

composer.json Outdated Show resolved Hide resolved
@SonataCI
Copy link
Collaborator

Could you please rebase your PR and fix merge conflicts?

@core23
Copy link
Member Author

core23 commented Feb 14, 2020

Closing in favor of #280

We also rely on sonata user bundle, which relies on fos user bundle, which is unmaintained / dead.

@core23 core23 closed this Feb 14, 2020
@core23 core23 deleted the symfony5 branch February 14, 2020 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants