Deprecate this bundle

[core23]

There are good and better maintained replacements on the market:

• https://github.com/twigphp/intl-extra
• https://github.com/symfony/polyfill-intl-icu

Refs #182

[core23]

cc @sonata-project/contributors

[greg0ire]

I'm all for it! There are some Sonata packages that depend on this:

• sonata-project/admin-bundle
• sonata-project/ecommerce
• sonata-project/media-bundle
• sonata-project/news-bundle
• sonata-project/timeline-bundle

[core23]

The only thing that we still need is the locale detector that updates the user entity.

[franmomu]

Trying to get rid of this bundle in TimelineBundle, the problem is that twig/intl-extra has "symfony/intl": "^4.3|^5.0" requirement and we have in Travis one job with symfony/symfony: 3.4.*.

[greg0ire]

I think it's ok to drop 3.4, we are only supposed to support one LTS at a time: https://github.com/sonata-project/SonataIntlBundle/blob/2.x/CONTRIBUTING.md#dependency-changes

[XWB]

@core23 Unfortunately twigphp/intl-extra only provides Twig filters for number and date formatting. AFAIK Symfony has no built in services to achieve something like:

use Sonata\IntlBundle\Templating\Helper\DateTimeHelper;

class MyClass
{
    private $dateTimeHelper;

    public function __construct(DateTimeHelper $dataTimeHelper)
    {
        $this->dateTimeHelper = $dataTimeHelper;
    }

    public function myFunction(string $format)
    {
        // to something with $this->dateTimeHelper
    }
}

[core23]

@core23 Unfortunately twigphp/intl-extra only provides Twig filters for number and date formatting. AFAIK Symfony has no built in services to achieve something like:

use Sonata\IntlBundle\Templating\Helper\DateTimeHelper;

class MyClass
{
    private $dateTimeHelper;

    public function __construct(DateTimeHelper $dataTimeHelper)
    {
        $this->dateTimeHelper = $dataTimeHelper;
    }

    public function myFunction(string $format)
    {
        // to something with $this->dateTimeHelper
    }
}

Maybe we could move from this bundle to the symfony bundle?

[VincentLanglet]

Shouldn't the readme be updated if this repository is deprecated ?

[core23]

Shouldn't the readme be updated if this repository is deprecated ?

Can you do this @VincentLanglet

[VincentLanglet]

Yes I can @core23
#296

But I also saw that the deprecated packages had this

I don't have the right to modify the description.

[greg0ire]

Thanks for pointing it out. Looks like I have the necessary permissions to do this, I just changed the description.

[VincentLanglet]

Thanks for pointing it out. Looks like I have the necessary permissions to do this, I just changed the description.

Can you do the same for https://github.com/sonata-project/SonataCacheBundle and https://github.com/sonata-project/SonataEasyExtendsBundle

[greg0ire]

Done (TIL the cache bundle is deprecated 😅)

[VincentLanglet]

Cf #300 (comment)