Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make remaining classes final #1301

Merged
merged 1 commit into from
Feb 10, 2021
Merged

make remaining classes final #1301

merged 1 commit into from
Feb 10, 2021

Conversation

dmaicher
Copy link
Contributor

@dmaicher dmaicher commented Feb 10, 2021 •
edited
Loading

Subject

I am targeting this branch, because this breaks BC.

This is part of #1187

No Changelog needed I think as its covered by the changelog of #1295

@dmaicher dmaicher changed the title make some more classes final make remaining classes final Feb 10, 2021
@dmaicher dmaicher marked this pull request as ready for review February 10, 2021 19:28
@dmaicher dmaicher requested a review from a team February 10, 2021 19:28
@VincentLanglet VincentLanglet requested a review from a team February 10, 2021 19:46
@greg0ire greg0ire merged commit 0eb5949 into sonata-project:master Feb 10, 2021
@greg0ire
Copy link
Contributor

Thanks @dmaicher !

@dmaicher dmaicher deleted the cleanup branch February 10, 2021 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet approved these changes

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmaicher @greg0ire @VincentLanglet