Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Next Major] Close API #1187

Closed
2 tasks done
VincentLanglet opened this issue Nov 5, 2020 · 2 comments
Closed
2 tasks done

[Next Major] Close API #1187

VincentLanglet opened this issue Nov 5, 2020 · 2 comments
Labels
major
Milestone
4.0

Comments

@VincentLanglet
Copy link
Member

VincentLanglet commented Nov 5, 2020 •
edited
Loading

  • Add final modifier
  • Reduce visibility to private if possible
@VincentLanglet VincentLanglet added this to the 4.0 milestone Nov 5, 2020
@VincentLanglet VincentLanglet mentioned this issue Feb 1, 2021
Merged
This was referenced Feb 4, 2021
Merged
Merged
@dmaicher
Copy link
Contributor

@VincentLanglet is there anything left to do for this one?

@VincentLanglet
Copy link
Member Author

For instance: https://github.com/sonata-project/SonataDoctrineORMAdminBundle/blob/master/src/Block/AuditBlockService.php#L31 can be private

That's all I found

@dmaicher dmaicher mentioned this issue Mar 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
2 participants
@dmaicher @VincentLanglet