-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for BlockBundle 4.x #522
Conversation
eae11cb
to
831a6a0
Compare
831a6a0
to
2e56fb1
Compare
@core23 What do you think about it? Can we remove AbstractAdminBlockService? @sonata-project/contribiutors |
* @deprecated since sonata-project/block-bundle 3.16, to be removed in version 4.0. | ||
*/ | ||
public function buildEditForm(FormMapper $form, BlockInterface $block) | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ | |
{ | |
$this->buildEditForm($formMapper, $block); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is AbstractAdminBlockService method, we should not change them. Self reference method make infinity loop.
Looking at Travis, sonata-block 4 is never resolved |
@core23 |
As said several time on many different issues. We had some major changes on the old core bundle and the block bundle. This changes can only be resolved with new major versions on our projects. The main goal is still a new admin bundle major version. After that we can try to find a way for all other projects. |
Could you please rebase your PR and fix merge conflicts? |
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@@ -23,8 +23,8 @@ | |||
"require": { | |||
"php": "^7.1", | |||
"cocur/slugify": "^2.0 || ^3.0 || ^4.0", | |||
"sonata-project/admin-bundle": "^3.31", | |||
"sonata-project/core-bundle": "^3.14", | |||
"sonata-project/admin-bundle": "^3.31 || dev-master", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not add this to the stable branch
Subject
@core23
After check #488 I think we can add support for BlockBundle 4.x. Can u check it?
I am targeting this branch, because it is PATCH.