Remove block deprecations #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core23
force-pushed
the
block-deprecations
branch
from
e2a5a6d to
fefd96e
Compare
core23
force-pushed
the
block-deprecations
branch
from
fefd96e to
3c3ab7f
Compare
core23
commented
Feb 15, 2020
| $this->categoryAdmin = $categoryAdmin; | ||
| // NEXT_MAJOR: remove the if block | ||
| if (\is_string($twigOrDeprecatedName)) { | ||
| parent::__construct( |
There was a problem hiding this comment.
We don't need any deprecation warning here, because the parent class will trigger one.
core23
force-pushed
the
block-deprecations
branch
3 times, most recently
from
3579782 to
3f8d968
Compare
|
Please check php-cs-fixer |
core23
force-pushed
the
block-deprecations
branch
from
3f8d968 to
9a2b6b4
Compare
greg0ire
approved these changes
Feb 16, 2020
franmomu
approved these changes
Feb 16, 2020
|
Thanks @core23 ! |
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because this is BC.
Changelog