Support doctrine/common 3 in 4.x #709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you retarget on 3.x so that it unlocks |
|
This one is no longer necessary |
|
The merge is not that easy, I'm not going to do it, can you push your branch again and reopen this @jaikdean ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
This PR adds support for
doctrine/common3. It follows the upgrade instructions in Doctrine's release notes.I am targeting this branch, because the change is back-compatible. This change should backport to 3.x with no other changes.
Also see corresponding PR for sonata-project/SonataAdminBundle#6127.
Changelog