Add doctrine/common 3 support

[jaikdean]

Subject

This PR adds support for doctrine/common 3. It follows the upgrade instructions in Doctrine's release notes.

I am targeting this branch, because the change is back-compatible.

Closes #6121.

Changelog

### Added
- Added support for `doctrine/common` 3.

[phansys]

The CI suite is yet using doctrine/common:2.13.2:
https://travis-ci.org/github/sonata-project/SonataAdminBundle/jobs/693376005#L605.

[jaikdean]

It looks like doctrine/common is restricted to 2.x by SonataBlockBundle. Should I create a PR to support 3.x in that package too? I'm not sure what's going on with the versioning and which branch to target, as SonataAdminBundle doesn't use the current major SonataBlockBundle.

[jordisala1991]

SonataBlock 3.19 released but doctrine common is still on 2.x, maybe there are more dependencies that block the install? @jaikdean

[jaikdean]

It seems the dependency tree here is a little more complex than I'd realised and will need updates to some third-party packages.

[greg0ire]

composer why-not folks 😉

composer why-not doctrine/common 3
sonata-project/admin-bundle  3.x-dev  requires          doctrine/common (^2.7)                         
doctrine/common              3.0.0    requires          doctrine/persistence (^2.0)                    
sonata-project/admin-bundle  3.x-dev  does not require  doctrine/persistence (but 1.3.7 is installed)  


composer why-not doctrine/persistence 2
doctrine/common                     2.13.2  requires  doctrine/persistence (^1.3.3)  
sonata-project/doctrine-extensions  1.6.0   requires  doctrine/persistence (^1.3.6)  
symfony/doctrine-bridge             v4.4.9  requires  doctrine/persistence (^1.3)

[phansys]

I'm allowing doctrine/persistence:^2.0 here: sonata-project/sonata-doctrine-extensions#203.

[jordisala1991]

The symfony doctrine bridge already has support for this, can you rebase to fix phpstan? Maybe we can merge this now

[jordisala1991]

Well, now the build uses the doctrine common 3 and the build fails. Can you fix it @jaikdean ?

[jaikdean]

I've fixed the compatibility issues with doctrine/persistence 2.0. The remaining issue is an incompatibility between symfony/security-acl (which receives minimal maintenance) and doctrine/common/doctrine/persistence. This package doesn't have a requirement or conflict for either listed in its composer.json, which is why it's allowing an incompatible version to be installed.

[SonataCI]

Could you please rebase your PR and fix merge conflicts?

[jordisala1991]

@jaikdean the security acl is already fixed

[jaikdean]

Thanks @jordisala1991.

This branch has been rebased and conflicts resolved. doctrine/common is now at version 3.

$ composer info doctrine/common
name     : doctrine/common
descrip. : PHP Doctrine Common project is a library that provides additional functionality that other Doctrine projects depend on such as better reflection support, persistence interfaces, proxies, event system and much more.
keywords : common, doctrine, php
versions : * 3.0.2
type     : library
license  : MIT License (MIT) (OSI approved) https://spdx.org/licenses/MIT.html#licenseText
homepage : https://www.doctrine-project.org/projects/common.html
source   : [git] https://github.com/doctrine/common.git a3c6479858989e242a2465972b4f7a8642baf0d4
dist     : [zip] https://api.github.com/repos/doctrine/common/zipball/a3c6479858989e242a2465972b4f7a8642baf0d4 a3c6479858989e242a2465972b4f7a8642baf0d4
path     : /Users/jaikdean/Documents/SonataAdminBundle/vendor/doctrine/common
names    : doctrine/common

[jordisala1991]

PHPStan is failing, are you sure you did a rebase with latest 3.x changes?

[jordisala1991]

ping @vladyslavstartsev any clues why it is failing? seems like the PR is rebased correctly.

[franmomu]

Looks like it's installing block-bundle 3.x in the phpstan action and the phpstan baseline errors are based on block-bundle4.x

[jordisala1991]

Oh so we need first to add support for doctrine common 3 on sonata block 4?

[franmomu]

It already has support, but I have no idea why in this action is installing block bundle 3:
https://github.com/sonata-project/SonataAdminBundle/pull/6127/checks?check_run_id=971548249#step:4:81

And in the last commit merged is installing block bundle 4:
https://github.com/sonata-project/SonataAdminBundle/runs/965815491#step:4:84

[jordisala1991]

Build is green and installing common 3, but before merge we need to know if those dependencies added are correct

[SonataCI]

Could you please rebase your PR and fix merge conflicts?

[jaikdean]

Rebased and merge conflicts resolved.

[jordisala1991]

Thank you @jaikdean