-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix submit filters #6877
Fix submit filters #6877
Conversation
Can you rebase in order to fix the conflict @willemverspyck ? |
Could you please rebase your PR and fix merge conflicts? |
…ndle into fix-submit-filters # Conflicts: # src/Admin/AbstractAdmin.php
Rebase and fix the conflict is done. Only I'm still having a problem during testing that I don't know how to fix: For example: If I set the default values like this in the Admin class:
And you remove this "status" filter and click on "Filter", then the filter will be back, because you don't pass this filter anymore with the GET parameters, but they are retrieved again from the "configureDefaultFilterValues" method. How would you solve this? Maybe create separate issue for this. |
This is another issue indeed. This should be handled by the JS and I think it's already solved. |
Thanks @willemverspyck |
Ok @phansys, I requested a new release for SonataAdminBundle via Slack in If you want to get notified about new releases, make sure to follow SonataNews on Twitter! |
Subject
Closes #6865
Changelog