Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix submit filters #6871

Merged
merged 3 commits into from
Feb 17, 2021
Merged

Fix submit filters #6871

merged 3 commits into from
Feb 17, 2021

Conversation

kirya-dev
Copy link
Contributor

@kirya-dev kirya-dev commented Feb 16, 2021 •
edited
Loading

Closes #6865.

Changelog

### Fixed
- Fix lost filter value when only type submitted
- Allow submit empty value when default filter non empty
- Invisible disabling filters (using remove name)

@VincentLanglet VincentLanglet requested a review from a team February 16, 2021 20:33
@VincentLanglet
Copy link
Member

I made multiple try with this code and I confirm that it seems to fix every issues. Nice work.

wbloszyk
wbloszyk approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@wbloszyk wbloszyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me looks good, anyway I am not good in js.

@VincentLanglet VincentLanglet requested a review from a team February 16, 2021 20:45
@willemverspyck willemverspyck mentioned this pull request Feb 17, 2021
Closed
@VincentLanglet VincentLanglet merged commit a5d58d9 into sonata-project:3.x Feb 17, 2021
@VincentLanglet
Copy link
Member

I totally forgot this wasn't working for filter with array values...

I'll wait for #6877 to make a release

@kirya-dev kirya-dev deleted the fix-submit-filters branch February 18, 2021 06:08
@VincentLanglet VincentLanglet mentioned this pull request Jun 11, 2021
Closed
@VincentLanglet VincentLanglet mentioned this pull request Dec 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet approved these changes

@wbloszyk wbloszyk wbloszyk approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Advanced filter value lost when changing default value type
3 participants
@kirya-dev @VincentLanglet @wbloszyk