Make Pool immutable #6735
Merged
Make Pool immutable #6735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
97
to
99
| $pool->replaceArgument(1, $config['title']); | ||
| $pool->replaceArgument(2, $config['title_logo']); | ||
| $pool->replaceArgument(3, $config['options']); |
There was a problem hiding this comment.
You're replacing argument 1, 2 and 3 in both AddDependencyCallsCompilerPass.php and here but with different values.
Shouldn't these lines be removed in favor of the setDeprecatedPropertiesForBC call ?
There was a problem hiding this comment.
I left them intentionally just in case some weird BC break, just to be safe, but I guess they can be removed.
VincentLanglet
previously approved these changes
Jan 5, 2021
|
Could you please rebase your PR and fix merge conflicts? |
franmomu
force-pushed
the
make_pool_immutable
branch
from
f9b0db5 to
38c93d0
Compare
|
Could you please rebase your PR and fix merge conflicts? |
franmomu
force-pushed
the
make_pool_immutable
branch
from
38c93d0 to
9f0191e
Compare
VincentLanglet
previously approved these changes
Jan 8, 2021
|
Could you please rebase your PR and fix merge conflicts? |
Setters have been deprecated in favor of passing the needed arguments to the constructor.
franmomu
force-pushed
the
make_pool_immutable
branch
from
9f0191e to
23697a8
Compare
VincentLanglet
approved these changes
Jan 8, 2021
OskarStark
approved these changes
Jan 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Ref: #6709
Poolworks as an Admin registry and its state is not needed to be changed once is instantiated, this PR will makePoolimmutable in4.0.Also
Poolmocks used in tests have been replaced by instances ofPool(the remaining ones are supposed to be removed in4.x).I am targeting this branch, because these changes are BC.
Closes #6709.
Changelog