Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Pool immutable #6709

Closed
franmomu opened this issue Dec 15, 2020 · 1 comment · Fixed by #6735
Closed

Make Pool immutable #6709

franmomu opened this issue Dec 15, 2020 · 1 comment · Fixed by #6735
Labels
feature

Comments

@franmomu
Copy link
Member

Feature Request

Since 3.83, Pool is just used as a registry for admin instances, but it still has setAdminServiceIds, setAdminGroups and setAdminClasses.

We could add these parameters in the constructor (I think these methods are always called in AddDependencyCallsCompilerPass) and there will be no need of setters anymore.
@VincentLanglet
Copy link
Member

VincentLanglet commented Jan 3, 2021 •
edited
Loading

Do you plan/want to do this before 4.0 release or I add the 5.0 milestone ? :)

@franmomu franmomu mentioned this issue Jan 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Pool immutable franmomu/SonataAdminBundle
2 participants
@franmomu @VincentLanglet