Deprecate Pool::getPropertyAccessor() method #6634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franmomu
force-pushed
the
deprecate_property_path_pool
branch
from
5f1e06c to
87fa44e
Compare
3 tasks
franmomu
force-pushed
the
deprecate_property_path_pool
branch
from
87fa44e to
3b567d6
Compare
VincentLanglet
requested changes
Nov 28, 2020
franmomu
force-pushed
the
deprecate_property_path_pool
branch
from
3b567d6 to
f8ede46
Compare
VincentLanglet
previously approved these changes
Nov 28, 2020
phansys
requested changes
Nov 29, 2020
franmomu
force-pushed
the
deprecate_property_path_pool
branch
from
f8ede46 to
74c15ad
Compare
phansys
requested changes
Nov 29, 2020
PropertyAccesor was added to Pool in order to reuse it for performance reasons in sonata-project#3488 In symfony/symfony#16838 cache was added to the component, so there is no need to reuse it thought the Pool service and it can be injected into the services.
franmomu
force-pushed
the
deprecate_property_path_pool
branch
from
74c15ad to
477d5d4
Compare
phansys
approved these changes
Nov 29, 2020
VincentLanglet
approved these changes
Nov 29, 2020
|
Thanks @franmomu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Ref: #6624
PropertyAccesor was added to Pool in order to reuse it for performance reasons in #3488.
In symfony/symfony#16838 cache was added to the component, so there is no need to reuse it thought the Pool service and it can be injected into the services.
I am targeting this branch, because these changes are BC.
Changelog