[RFC] Use Pool just as a registry

[franmomu]

Feature Request

Looking at Pool class we can improve it in some ways, these are my thoughts:

• Extract title, logo and options to a Configuration class, these parameters are used as configuration for the whole project, they shouldn't be needed for instantiate a Pool. Introduce SonataConfiguration class #6640
• Remove PropertyAccessor, it was added for reuse, but after that cache was added to the component, so we can remove it and inject PropertyAccessor where is needed. Deprecate Pool::getPropertyAccessor() method #6634
• Inject a ServiceLocator with only the admin services, so we wouldn't need them to be public. Inject a ServiceLocator to Pool instead of container #6733

After this the Pool class would be use just a registry for admin classes which I think it was meant to be.

The last one I guess it cannot be done with BC, but the other two we can deprecate those parameters in the Pool class.

WDYT? @sonata-project/contributors

[VincentLanglet]

• Remove PropertyAccessor, it was added for reuse, but after that cache was added to the component, so we can remove it and inject PropertyAccessor where is needed.

I strongly agree with this.
The AdminHelper has a dependency on the pool only to use the PropertyAccessor. This seems overkill.

Will you have some time to provide a PR ?

[franmomu]

I'll make a couple of PR, I started making these changes, just wanted to check to keep going.

[VincentLanglet]

Hi @franmomu, do you plan/want to do the last point before the 4.0 release or I add the 5.0 milestone ?

[franmomu]

I have both Pool related issues half way done, I'll try to make the PRs today.