-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] Add validator related deprecation notices #6633
[3.x] Add validator related deprecation notices #6633
Conversation
6b18d22
to
02784c1
Compare
src/DependencyInjection/Compiler/AddDependencyCallsCompilerPass.php
Outdated
Show resolved
Hide resolved
src/Admin/AbstractAdmin.php
Outdated
public function setValidator($validator) | ||
{ | ||
@trigger_error(sprintf( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method is automatically called by the CompilerPass, so I think we can't trigger an error inside (or everybody will have a deprecation everytime). @sonata-project/contributors ?
95a5692
to
b6e0708
Compare
Didn't see the tests ; do you know how to fix them ?
|
e8f916f
to
c6b040b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing, you have to update the UPGRADE note file, and the PR will be perfect
Thanks. I wouldn't know how to fix tests without your help. |
c6b040b
to
6c3dbcc
Compare
6c3dbcc
to
f71e220
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is also this one:
SonataAdminBundle/tests/Admin/AdminTest.php
Lines 2841 to 2843 in c30d61e
$validator = $this->createMock(ValidatorInterface::class); | |
$validator->method('getMetadataFor')->willReturn($this->createStub(MemberMetadata::class)); | |
$admin->setValidator($validator); |
7912b82
to
5296b8f
Compare
5296b8f
to
c143ddf
Compare
Could you please rebase your PR and fix merge conflicts? |
Could you please rebase your PR and fix merge conflicts? |
Subject
I am targeting this branch, because BC.
Changelog